Re: [PATCH 0/2] Update use_goto_tb() in hppa and rx targets

2020-05-26 Thread Aleksandar Markovic
> > > > I think your last sentence in the bug report is not entirely correct. > > It is not known what would be performance results in case of > > correcting mmap.c. So, if possible, and unless Richard or someone else > > disagrees, please change that last sentence to: "By doing so, a better > >

Re: [PATCH 0/2] Update use_goto_tb() in hppa and rx targets

2020-05-26 Thread Aleksandar Markovic
Mr. Ahmed, The title "Changing executable page permissions with mmap causes user-mode failures", I know you paraphrased one of Richard's responses, but you picked up those pieces that don't convey the complete, larger, picture. So, the better, more inclusive, and much clearer title would be

Re: [PATCH 0/2] Update use_goto_tb() in hppa and rx targets

2020-05-26 Thread Aleksandar Markovic
уто, 26. мај 2020. у 18:08 Ahmed Karaman је написао/ла: > > On Tue, May 26, 2020 at 4:14 PM Aleksandar Markovic > wrote: > > Ahmed, please follow the instructions on this page: How to report a QEMU > > bug and file the bug related to the discussion, to the best of your > > abilities, if

Re: [PATCH 0/2] Update use_goto_tb() in hppa and rx targets

2020-05-26 Thread Ahmed Karaman
On Tue, May 26, 2020 at 4:14 PM Aleksandar Markovic wrote: > Ahmed, please follow the instructions on this page: How to report a QEMU bug > and file the bug related to the discussion, to the best of your abilities, if > possible, today. Please find the link to the bug below:

Re: [PATCH 0/2] Update use_goto_tb() in hppa and rx targets

2020-05-26 Thread Aleksandar Markovic
> If nobody objects, I will instruct Ahmed to file a bug in QEMU Bugzilla. > Ahmed, please follow the instructions on this page: How to report a QEMU bug and file the bug related to the discussion, to the best of your abilities, if possible, today.

Re: [PATCH 0/2] Update use_goto_tb() in hppa and rx targets

2020-05-25 Thread Aleksandar Markovic
пет, 22. мај 2020. у 05:12 Richard Henderson је написао/ла: > > On 5/21/20 4:32 AM, Ahmed Karaman wrote: > > Does this mean that there is a bug > > in this function for the other targets? > > Yes, I think so. > > > That we have to do the page crossings check in both modes to avoid the > >

Re: [PATCH 0/2] Update use_goto_tb() in hppa and rx targets

2020-05-21 Thread Richard Henderson
On 5/21/20 4:32 AM, Ahmed Karaman wrote: > Does this mean that there is a bug > in this function for the other targets? Yes, I think so. > That we have to do the page crossings check in both modes to avoid the > user-mode failures that you have mentioned above? Well, that or we need to fix

Re: [PATCH 0/2] Update use_goto_tb() in hppa and rx targets

2020-05-21 Thread Ahmed Karaman
On Tue, May 19, 2020 at 8:01 PM Richard Henderson wrote: > > On 5/19/20 9:21 AM, Ahmed Karaman wrote: > > The issue arose because the page crossings check in use_goto_tb() > > function is required only in the system mode. Checking it in both > > modes causes an unnecessary overhead in the user

Re: [PATCH 0/2] Update use_goto_tb() in hppa and rx targets

2020-05-19 Thread Richard Henderson
On 5/19/20 11:38 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> On 5/19/20 9:21 AM, Ahmed Karaman wrote: >>> The issue arose because the page crossings check in use_goto_tb() >>> function is required only in the system mode. Checking it in both modes >>> causes an unnecessary

Re: [PATCH 0/2] Update use_goto_tb() in hppa and rx targets

2020-05-19 Thread Alex Bennée
Richard Henderson writes: > On 5/19/20 9:21 AM, Ahmed Karaman wrote: >> The issue arose because the page crossings check in use_goto_tb() >> function is required only in the system mode. Checking it in both modes >> causes an unnecessary overhead in the user mode. > > It is not only required

Re: [PATCH 0/2] Update use_goto_tb() in hppa and rx targets

2020-05-19 Thread Richard Henderson
On 5/19/20 9:21 AM, Ahmed Karaman wrote: > The issue arose because the page crossings check in use_goto_tb() > function is required only in the system mode. Checking it in both modes > causes an unnecessary overhead in the user mode. It is not only required in system mode. You can see failures

[PATCH 0/2] Update use_goto_tb() in hppa and rx targets

2020-05-19 Thread Ahmed Karaman
Greetings to all QEMU developers! First of all, I want to say I'm really honored that I will be working with you on the Google Summer of Code project "TCG Continuous Benchmarking" this June, July and August. This is my first set of patches sent to the QEMU mailing list, that came up as a result