Re: [PATCH 0/3] hw/acpi/cpu_hotplug: Convert 'Object *device' -> 'DeviceState *parent'

2023-02-28 Thread Michael S. Tsirkin
On Tue, Feb 28, 2023 at 04:47:31PM +0100, Igor Mammedov wrote: > On Tue, 28 Feb 2023 14:36:43 +0100 > Philippe Mathieu-Daudé wrote: > > > ping^2 > > please use checkpatch before pasting series. > > Object -> DeviceState is a nice cleanup, I don't like that one either because everyone wants

Re: [PATCH 0/3] hw/acpi/cpu_hotplug: Convert 'Object *device' -> 'DeviceState *parent'

2023-02-28 Thread Igor Mammedov
On Tue, 28 Feb 2023 14:36:43 +0100 Philippe Mathieu-Daudé wrote: > ping^2 please use checkpatch before pasting series. Object -> DeviceState is a nice cleanup, the rest is just unnecessary churn in my opinion and a matter of taste, but I fine with it if it makes code easier to read for someone

Re: [PATCH 0/3] hw/acpi/cpu_hotplug: Convert 'Object *device' -> 'DeviceState *parent'

2023-02-28 Thread Philippe Mathieu-Daudé
ping^2 On 22/2/23 22:34, Philippe Mathieu-Daudé wrote: On 3/2/23 17:30, Philippe Mathieu-Daudé wrote: To ease code review, rename ACPI CPU hotplug variables to more meaningful names. Since hotplug parent can't be any QOM object, and must be a QDev, convert AcpiCpuHotplug::device from Object*

Re: [PATCH 0/3] hw/acpi/cpu_hotplug: Convert 'Object *device' -> 'DeviceState *parent'

2023-02-22 Thread Philippe Mathieu-Daudé
On 3/2/23 17:30, Philippe Mathieu-Daudé wrote: To ease code review, rename ACPI CPU hotplug variables to more meaningful names. Since hotplug parent can't be any QOM object, and must be a QDev, convert AcpiCpuHotplug::device from Object* to DeviceState*. Philippe Mathieu-Daudé (3):

[PATCH 0/3] hw/acpi/cpu_hotplug: Convert 'Object *device' -> 'DeviceState *parent'

2023-02-03 Thread Philippe Mathieu-Daudé
To ease code review, rename ACPI CPU hotplug variables to more meaningful names. Since hotplug parent can't be any QOM object, and must be a QDev, convert AcpiCpuHotplug::device from Object* to DeviceState*. Philippe Mathieu-Daudé (3): hw/acpi/cpu_hotplug: Rename gpe_cpu -> gpe