Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-17 Thread Claudio Fontana
On 6/17/21 11:48 AM, Gerd Hoffmann wrote: > Hi, > >> Do we need to be able to unload modules that we previously loaded? Or is >> this not a realistic requirement? > > Surely doable, but it's work and needs infrastructure we don't have > right now. We must be able to unregister everything

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-17 Thread Gerd Hoffmann
Hi, > Do we need to be able to unload modules that we previously loaded? Or is this > not a realistic requirement? Surely doable, but it's work and needs infrastructure we don't have right now. We must be able to unregister everything modules can register, which is only partly the case

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-17 Thread Claudio Fontana
On 6/17/21 7:37 AM, Gerd Hoffmann wrote: > Hi, > However, please correct me if I'm wrong, I understand that an accelerator as a module will add an overhead that some user won't be willing to pay. So, give them the option to have built-in accelerators seems a good

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-16 Thread Gerd Hoffmann
Hi, > >> However, please correct me if I'm wrong, I understand that an accelerator > >> as a > >> module will add an overhead that some user won't be willing to pay. So, > >> give > >> them the option to have built-in accelerators seems a good idea. > > > > Modules add some overhead, yes,

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-16 Thread Claudio Fontana
On 6/16/21 11:28 AM, Gerd Hoffmann wrote: >>> Hmm, what would be the use case? Right now qemu has the all-or-nothing >>> approach for modules, i.e. if modules are enabled everything we can >>> build as module will be built as module, and I havn't seen any drawbacks >>> so far. So, why would one

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-16 Thread Gerd Hoffmann
> > Hmm, what would be the use case? Right now qemu has the all-or-nothing > > approach for modules, i.e. if modules are enabled everything we can > > build as module will be built as module, and I havn't seen any drawbacks > > so far. So, why would one compile parts of qemu as module and other

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-15 Thread José Ricardo Ziviani
On terça-feira, 15 de junho de 2021 02:09:30 -03 Gerd Hoffmann wrote: > On Mon, Jun 14, 2021 at 10:19:27PM +, José Ricardo Ziviani wrote: > > Hello Gerd, > > > > On sexta-feira, 11 de junho de 2021 10:03:21 -03 Gerd Hoffmann wrote: > > > Hi, > > > > > > > Are there any pending patches to

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-14 Thread Gerd Hoffmann
On Mon, Jun 14, 2021 at 10:19:27PM +, José Ricardo Ziviani wrote: > Hello Gerd, > > On sexta-feira, 11 de junho de 2021 10:03:21 -03 Gerd Hoffmann wrote: > > Hi, > > > > > Are there any pending patches to handle the remaining tcg dependencies > > > in qemu? When trying to build tcg

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-14 Thread José Ricardo Ziviani
N¬ŠÆ¦º[b¥ªí™ë,j¢œÂ ú+™«g{Oj»vëß:넉ˆâè4f ‰íz{S­©ì}êĝÊŠx*º‹^všâžÖ›•à¨ž×§µ<©z×±·úej)܅ªìz signature.asc Description: This is a digitally signed message part.

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-11 Thread Paolo Bonzini
On 11/06/21 10:29, Gerd Hoffmann wrote: Are there any pending patches to handle the remaining tcg dependencies in qemu? When trying to build tcg modular (more than only tcg-accel-ops*) I get lots of unresolved symbols to tcg bits which are referenced directly (in cpu.c, gdbstub.c, monitor,

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-11 Thread Claudio Fontana
On 6/11/21 3:03 PM, Gerd Hoffmann wrote: > Hi, > >> Are there any pending patches to handle the remaining tcg dependencies >> in qemu? When trying to build tcg modular (more than only >> tcg-accel-ops*) I get lots of unresolved symbols to tcg bits which are >> referenced directly (in cpu.c,

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-11 Thread Gerd Hoffmann
Hi, > Are there any pending patches to handle the remaining tcg dependencies > in qemu? When trying to build tcg modular (more than only > tcg-accel-ops*) I get lots of unresolved symbols to tcg bits which are > referenced directly (in cpu.c, gdbstub.c, monitor, ...). > > The CONFIG_TCG=n

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-11 Thread Gerd Hoffmann
On Fri, Jun 11, 2021 at 09:35:42AM +0200, Paolo Bonzini wrote: > On 10/06/21 15:12, Claudio Fontana wrote: > > The difficulty is that accelerator code is going to be split across a > > large number of directories. We basically have to define the source sets at the toplevel meson.build file, then

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-11 Thread Paolo Bonzini
On 10/06/21 15:12, Claudio Fontana wrote: The difficulty is that accelerator code is going to be split across a large number of directories. It should be possible to use a sourceset per target; just like there is target_arch, target_softmmu_arch, target_user_arch we can add

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-10 Thread Claudio Fontana
On 6/10/21 2:23 PM, Gerd Hoffmann wrote: > On Thu, Jun 10, 2021 at 12:34:14PM +0200, Claudio Fontana wrote: >> On 6/10/21 12:15 PM, Gerd Hoffmann wrote: >>> Based on the "modules: add metadata database" patch series sent >>> earlier today. Adds support for target-specific modules to the >>>

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-10 Thread Gerd Hoffmann
Hi, > Build qtest modular on top of that was easy, patch below. > > I'm not convinced though that the approach will work for other > accelerators too given that they have dependencies to directories > outside accel/ ... Oh, it depends on how high you hang the tcg modularization bar. Building

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-10 Thread Gerd Hoffmann
On Thu, Jun 10, 2021 at 12:34:14PM +0200, Claudio Fontana wrote: > On 6/10/21 12:15 PM, Gerd Hoffmann wrote: > > Based on the "modules: add metadata database" patch series sent > > earlier today. Adds support for target-specific modules to the > > module code and build infrastructure. Builds one

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-10 Thread Claudio Fontana
On 6/10/21 12:15 PM, Gerd Hoffmann wrote: > Based on the "modules: add metadata database" patch series sent > earlier today. Adds support for target-specific modules to the > module code and build infrastructure. Builds one simple module > (virtio-9p-device) for testing purposes. Well, one

[PATCH 0/4] modules: add support for target-specific modules.

2021-06-10 Thread Gerd Hoffmann
Based on the "modules: add metadata database" patch series sent earlier today. Adds support for target-specific modules to the module code and build infrastructure. Builds one simple module (virtio-9p-device) for testing purposes. Well, one module per target to be exact ;) Gerd Hoffmann (4):