Re: [PATCH 0/5] Stop adding HMP-only commands, allow QMP for all

2021-09-09 Thread Daniel P . Berrangé
On Thu, Sep 09, 2021 at 06:48:21AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Wed, Sep 08, 2021 at 05:09:13PM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > We are still adding HMP commands without any QMP counterparts. This is > >> >

Re: [PATCH 0/5] Stop adding HMP-only commands, allow QMP for all

2021-09-09 Thread Markus Armbruster
Markus Armbruster writes: [...] > Limitations: > > 1. If we convert a long-running HMP command to this technique, we print >its output only after it completed its work. We also end up with a >long-running QMP command, which is bad, because it stops the main >loop and makes the QMP

Re: [PATCH 0/5] Stop adding HMP-only commands, allow QMP for all

2021-09-09 Thread Paolo Bonzini
On 08/09/21 17:09, Markus Armbruster wrote: This is 77 out of 170 HMP commands. I was hoping for fewer. There are several that are not quite 1:1, but still not HMP-specific. exit_preconfig This is x-exit-preconfig. migrate_set_capability migrate_set_parameter These are

Re: [PATCH 0/5] Stop adding HMP-only commands, allow QMP for all

2021-09-08 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Sep 08, 2021 at 05:09:13PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > We are still adding HMP commands without any QMP counterparts. This is >> > done because there are a reasonable number of scenarios where the cost >> > of

Re: [PATCH 0/5] Stop adding HMP-only commands, allow QMP for all

2021-09-08 Thread Philippe Mathieu-Daudé
On 9/8/21 5:09 PM, Markus Armbruster wrote: > Daniel P. Berrangé writes: > >> We are still adding HMP commands without any QMP counterparts. This is >> done because there are a reasonable number of scenarios where the cost >> of designing a QAPI data type for the command is not justified. >> >>

Re: [PATCH 0/5] Stop adding HMP-only commands, allow QMP for all

2021-09-08 Thread Daniel P . Berrangé
On Wed, Sep 08, 2021 at 05:09:13PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > We are still adding HMP commands without any QMP counterparts. This is > > done because there are a reasonable number of scenarios where the cost > > of designing a QAPI data type for the

Re: [PATCH 0/5] Stop adding HMP-only commands, allow QMP for all

2021-09-08 Thread Markus Armbruster
Daniel P. Berrangé writes: > We are still adding HMP commands without any QMP counterparts. This is > done because there are a reasonable number of scenarios where the cost > of designing a QAPI data type for the command is not justified. > > This has the downside, however, that we will never be

Re: [PATCH 0/5] Stop adding HMP-only commands, allow QMP for all

2021-09-08 Thread Ján Tomko
On a Wednesday in 2021, Daniel P. Berrangé wrote: We are still adding HMP commands without any QMP counterparts. This is done because there are a reasonable number of scenarios where the cost of designing a QAPI data type for the command is not justified. This has the downside, however, that we

[PATCH 0/5] Stop adding HMP-only commands, allow QMP for all

2021-09-08 Thread Daniel P . Berrangé
We are still adding HMP commands without any QMP counterparts. This is done because there are a reasonable number of scenarios where the cost of designing a QAPI data type for the command is not justified. This has the downside, however, that we will never be able to fully isolate the monitor