Re: [PATCH 0/7] build: replace ninjatool with ninja

2020-10-16 Thread Mark Cave-Ayland
On 15/10/2020 22:41, Paolo Bonzini wrote: Il gio 15 ott 2020, 20:49 Mark Cave-Ayland > ha scritto: Is there any reason why https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg06997.html

Re: [PATCH 0/7] build: replace ninjatool with ninja

2020-10-15 Thread Howard Spoelstra
On Thu, Oct 15, 2020 at 7:39 PM Volker Rümelin wrote: > > > > > Thanks Paolo, > > > > Then only the issue regarding the pcbios/optionrom stuff remains ;-) > > > > make[1]: *** No rule to make target 'multiboot.bin', needed by 'all'. > Stop. > > make: *** [Makefile:171: pc-bios/optionrom/all]

Re: [PATCH 0/7] build: replace ninjatool with ninja

2020-10-15 Thread Paolo Bonzini
Il gio 15 ott 2020, 20:49 Mark Cave-Ayland ha scritto: > Is there any reason why > https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg06997.html still > can't be > merged? > Because it's not the right approach. There is no reason why building firmware cannot be done with cross compilers,

Re: [PATCH 0/7] build: replace ninjatool with ninja

2020-10-15 Thread Mark Cave-Ayland
On 15/10/2020 18:39, Volker Rümelin wrote: Thanks Paolo, Then only the issue regarding the pcbios/optionrom stuff remains ;-) make[1]: *** No rule to make target 'multiboot.bin', needed by 'all'.  Stop. make: *** [Makefile:171: pc-bios/optionrom/all] Error 2 make: *** Waiting for unfinished

Re: [PATCH 0/7] build: replace ninjatool with ninja

2020-10-15 Thread Yonggang Luo
On Wed, Oct 14, 2020 at 9:58 PM Paolo Bonzini wrote: > > This pull request is the last build system change for 5.2 from > me, and it is simple: similar to how we are invoking > ROM or tests/tcg "make" from the main Makefile, we now invoke ninja > to build QEMU. Unlike those cases, however,

Re: [PATCH 0/7] build: replace ninjatool with ninja

2020-10-15 Thread Volker Rümelin
> > Thanks Paolo, > > Then only the issue regarding the pcbios/optionrom stuff remains ;-) > > make[1]: *** No rule to make target 'multiboot.bin', needed by 'all'.  Stop. > make: *** [Makefile:171: pc-bios/optionrom/all] Error 2 > make: *** Waiting for unfinished jobs > > Best, > Howard >

Re: [PATCH 0/7] build: replace ninjatool with ninja

2020-10-15 Thread Paolo Bonzini
On 15/10/20 09:39, Howard Spoelstra wrote: > > > Thanks Paolo, > > Then only the issue regarding the pcbios/optionrom stuff remains ;-) > > make[1]: *** No rule to make target 'multiboot.bin', needed by 'all'.  Stop. > make: *** [Makefile:171: pc-bios/optionrom/all] Error 2 > make: *** Waiting

Re: [PATCH 0/7] build: replace ninjatool with ninja

2020-10-15 Thread Howard Spoelstra
On Thu, Oct 15, 2020 at 8:34 AM Paolo Bonzini wrote: > On 15/10/20 08:15, Howard Spoelstra wrote: > > ERROR: meson setup failed > > > > When I set --ninja=ninja explicitly, this error does not occur: > > Found ninja.EXE-1.10.1 at C:\msys64\mingw64\bin/ninja.EXE > > That is fixed by Meson 0.55.2,

Re: [PATCH 0/7] build: replace ninjatool with ninja

2020-10-15 Thread Paolo Bonzini
On 15/10/20 08:15, Howard Spoelstra wrote: > ERROR: meson setup failed > > When I set --ninja=ninja explicitly, this error does not occur: > Found ninja.EXE-1.10.1 at C:\msys64\mingw64\bin/ninja.EXE That is fixed by Meson 0.55.2, I'll add a submodule update. Thanks for the reminder! Paolo

Re: [PATCH 0/7] build: replace ninjatool with ninja

2020-10-15 Thread Howard Spoelstra
On Wed, Oct 14, 2020 at 3:57 PM Paolo Bonzini wrote: > This pull request is the last build system change for 5.2 from > me, and it is simple: similar to how we are invoking > ROM or tests/tcg "make" from the main Makefile, we now invoke ninja > to build QEMU. Unlike those cases, however,

Re: [PATCH 0/7] build: replace ninjatool with ninja

2020-10-14 Thread Peter Maydell
On Wed, 14 Oct 2020 at 14:54, Paolo Bonzini wrote: > > This pull request is the last build system change for 5.2 from > me, and it is simple: similar to how we are invoking > ROM or tests/tcg "make" from the main Makefile, we now invoke ninja > to build QEMU. Unlike those cases, however,

[PATCH 0/7] build: replace ninjatool with ninja

2020-10-14 Thread Paolo Bonzini
This pull request is the last build system change for 5.2 from me, and it is simple: similar to how we are invoking ROM or tests/tcg "make" from the main Makefile, we now invoke ninja to build QEMU. Unlike those cases, however, build.ninja targets are forwarded transparently. The advantages