Re: [PATCH 0/7] hw/misc/empty_slot: Spring cleaning

2020-06-08 Thread Philippe Mathieu-Daudé
On 5/10/20 5:28 PM, Philippe Mathieu-Daudé wrote: > New Spring, new opportunity to clean this device :) > (v1 was in 2018, v2 in 2019). > > - lower device priority > - follow qdev model and use properties > - convert to trace events > - describe with slot name > - move under hw/misc/ and cover in

Re: [PATCH 0/7] hw/misc/empty_slot: Spring cleaning

2020-06-08 Thread Artyom Tarasenko
On Sun, May 24, 2020 at 10:21 PM Philippe Mathieu-Daudé wrote: > > On 5/24/20 9:37 PM, Aleksandar Markovic wrote: > > нед, 24. мај 2020. у 18:58 Philippe Mathieu-Daudé > > је написао/ла: > >> > >> ping? > >> > > > > I agree with all of your patches, they absolutely make sense to me, > > but I

Re: [PATCH 0/7] hw/misc/empty_slot: Spring cleaning

2020-05-24 Thread Peter Maydell
On Sun, 24 May 2020 at 21:21, Philippe Mathieu-Daudé wrote: > On 5/24/20 9:37 PM, Aleksandar Markovic wrote: > > I agree with all of your patches, they absolutely make sense to me, > > but I would like to know Peter's opinion on such treatment of empty > > slots. > > > > I am going to give r-bs

Re: [PATCH 0/7] hw/misc/empty_slot: Spring cleaning

2020-05-24 Thread Philippe Mathieu-Daudé
On 5/24/20 9:37 PM, Aleksandar Markovic wrote: > нед, 24. мај 2020. у 18:58 Philippe Mathieu-Daudé > је написао/ла: >> >> ping? >> > > I agree with all of your patches, they absolutely make sense to me, > but I would like to know Peter's opinion on such treatment of empty > slots. > > I am

Re: [PATCH 0/7] hw/misc/empty_slot: Spring cleaning

2020-05-24 Thread Aleksandar Markovic
нед, 24. мај 2020. у 18:58 Philippe Mathieu-Daudé је написао/ла: > > ping? > I agree with all of your patches, they absolutely make sense to me, but I would like to know Peter's opinion on such treatment of empty slots. I am going to give r-bs and integrate mips patches as soon as Peter OKs the

Re: [PATCH 0/7] hw/misc/empty_slot: Spring cleaning

2020-05-24 Thread Philippe Mathieu-Daudé
ping? On 5/10/20 5:28 PM, Philippe Mathieu-Daudé wrote: > New Spring, new opportunity to clean this device :) > (v1 was in 2018, v2 in 2019). > > - lower device priority > - follow qdev model and use properties > - convert to trace events > - describe with slot name > - move under hw/misc/ and

[PATCH 0/7] hw/misc/empty_slot: Spring cleaning

2020-05-10 Thread Philippe Mathieu-Daudé
New Spring, new opportunity to clean this device :) (v1 was in 2018, v2 in 2019). - lower device priority - follow qdev model and use properties - convert to trace events - describe with slot name - move under hw/misc/ and cover in MAINTAINERS Peter, I hope you are OK adding it wit UNIMP device,