Re: [PATCH 0/7] libqos: add VIRTIO PCI 1.0 support

2019-10-11 Thread Stefan Hajnoczi
On Thu, Oct 10, 2019 at 02:12:00PM -0700, no-re...@patchew.org wrote: > 4/7 Checking commit e3477ab2dc8e (libqos: add MSI-X callbacks to > QVirtioPCIDevice) > ERROR: line over 90 characters > #31: FILE: tests/libqos/virtio-pci.c:283: > +static void qvirtio_pci_set_queue_vector(QVirtioPCIDevice

Re: [PATCH 0/7] libqos: add VIRTIO PCI 1.0 support

2019-10-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191010155853.4325-1-stefa...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 0/7] libqos: add VIRTIO PCI 1.0 support Type: series Message-id: 20191010155853.4325-1-stefa

[PATCH 0/7] libqos: add VIRTIO PCI 1.0 support

2019-10-10 Thread Stefan Hajnoczi
New VIRTIO devices are Non-Transitional. This means they only expose the VIRTIO 1.0 PCI register interface. The libqos virtio-pci.c code only supports Legacy and Transitional devices (in Legacy mode). This patch series add VIRTIO PCI 1.0 support so that tests can run against Non-Transitional