Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-25 Thread Matthew Rosato
On 1/22/21 11:46 AM, Cornelia Huck wrote: On Thu, 21 Jan 2021 13:06:24 -0500 Matthew Rosato wrote: On 1/21/21 12:50 PM, Cornelia Huck wrote: On Thu, 21 Jan 2021 15:54:22 +0100 Niklas Schnelle wrote: On 1/21/21 3:46 PM, Pierre Morel wrote: On 1/21/21 2:37 PM, Niklas Schnelle wrote:

Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-22 Thread Cornelia Huck
On Thu, 21 Jan 2021 13:06:24 -0500 Matthew Rosato wrote: > On 1/21/21 12:50 PM, Cornelia Huck wrote: > > On Thu, 21 Jan 2021 15:54:22 +0100 > > Niklas Schnelle wrote: > > > >> On 1/21/21 3:46 PM, Pierre Morel wrote: > >>> > >>> > >>> On 1/21/21 2:37 PM, Niklas Schnelle wrote: > > >>>

Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-21 Thread Matthew Rosato
On 1/21/21 12:50 PM, Cornelia Huck wrote: On Thu, 21 Jan 2021 15:54:22 +0100 Niklas Schnelle wrote: On 1/21/21 3:46 PM, Pierre Morel wrote: On 1/21/21 2:37 PM, Niklas Schnelle wrote: On 1/21/21 1:30 PM, Pierre Morel wrote: Just wanted to say that we've had a very similar discussion

Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-21 Thread Cornelia Huck
On Thu, 21 Jan 2021 15:54:22 +0100 Niklas Schnelle wrote: > On 1/21/21 3:46 PM, Pierre Morel wrote: > > > > > > On 1/21/21 2:37 PM, Niklas Schnelle wrote: > >> > >> > >> On 1/21/21 1:30 PM, Pierre Morel wrote: > > > > Just wanted to say that we've had a very similar discussion

Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-21 Thread Pierre Morel
On 1/21/21 3:42 PM, Matthew Rosato wrote: On 1/21/21 3:27 AM, Pierre Morel wrote: On 1/20/21 9:29 PM, Matthew Rosato wrote: On 1/20/21 2:18 PM, Pierre Morel wrote: ...snip... So we have: devices supporting MIO and MSIX devices not supporting MIO nor MSIX devices not supporting the us

Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-21 Thread Niklas Schnelle
On 1/21/21 3:46 PM, Pierre Morel wrote: > > > On 1/21/21 2:37 PM, Niklas Schnelle wrote: >> >> >> On 1/21/21 1:30 PM, Pierre Morel wrote: > Just wanted to say that we've had a very similar discussion with Cornelia end of last year and came to the conclusion that explicitly

Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-21 Thread Pierre Morel
On 1/21/21 2:37 PM, Niklas Schnelle wrote: On 1/21/21 1:30 PM, Pierre Morel wrote: Just wanted to say that we've had a very similar discussion with Cornelia end of last year and came to the conclusion that explicitly matching the PFT is likely the safest bet: https://lkml.org/lkml/2020/1

Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-21 Thread Matthew Rosato
On 1/21/21 3:27 AM, Pierre Morel wrote: On 1/20/21 9:29 PM, Matthew Rosato wrote: On 1/20/21 2:18 PM, Pierre Morel wrote: ...snip... So we have: devices supporting MIO and MSIX devices not supporting MIO nor MSIX devices not supporting the use of PCISTG to emulate PCISTB The first two a

Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-21 Thread Niklas Schnelle
On 1/21/21 1:30 PM, Pierre Morel wrote: > > > On 1/21/21 10:58 AM, Niklas Schnelle wrote: >> >> >> On 1/21/21 9:27 AM, Pierre Morel wrote: >>> >>> >>> On 1/20/21 9:29 PM, Matthew Rosato wrote: On 1/20/21 2:18 PM, Pierre Morel wrote: > > >>> ...snip... >>> So, I mean I ca

Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-21 Thread Pierre Morel
On 1/21/21 10:58 AM, Niklas Schnelle wrote: On 1/21/21 9:27 AM, Pierre Morel wrote: On 1/20/21 9:29 PM, Matthew Rosato wrote: On 1/20/21 2:18 PM, Pierre Morel wrote: ...snip... So, I mean I can change the code to be more permissive in that way (allow any device that doesn't have

Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-21 Thread Niklas Schnelle
On 1/21/21 9:27 AM, Pierre Morel wrote: > > > On 1/20/21 9:29 PM, Matthew Rosato wrote: >> On 1/20/21 2:18 PM, Pierre Morel wrote: >>> >>> > ...snip... > >> >> So, I mean I can change the code to be more permissive in that way (allow >> any device that doesn't have MSI-X capability to at lea

Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-21 Thread Pierre Morel
On 1/20/21 9:29 PM, Matthew Rosato wrote: On 1/20/21 2:18 PM, Pierre Morel wrote: ...snip... So we have: devices supporting MIO and MSIX devices not supporting MIO nor MSIX devices not supporting the use of PCISTG to emulate PCISTB The first two are two different things indicated by two

Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-20 Thread Matthew Rosato
On 1/20/21 2:18 PM, Pierre Morel wrote: On 1/20/21 4:59 PM, Matthew Rosato wrote: On 1/20/21 9:45 AM, Pierre Morel wrote: On 1/20/21 3:03 PM, Matthew Rosato wrote: On 1/20/21 4:12 AM, Pierre Morel wrote: On 1/19/21 9:44 PM, Matthew Rosato wrote: Today, ISM devices are completely disallo

Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-20 Thread Pierre Morel
On 1/20/21 4:59 PM, Matthew Rosato wrote: On 1/20/21 9:45 AM, Pierre Morel wrote: On 1/20/21 3:03 PM, Matthew Rosato wrote: On 1/20/21 4:12 AM, Pierre Morel wrote: On 1/19/21 9:44 PM, Matthew Rosato wrote: Today, ISM devices are completely disallowed for vfio-pci passthrough as QEMU re

Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-20 Thread Matthew Rosato
On 1/20/21 9:45 AM, Pierre Morel wrote: On 1/20/21 3:03 PM, Matthew Rosato wrote: On 1/20/21 4:12 AM, Pierre Morel wrote: On 1/19/21 9:44 PM, Matthew Rosato wrote: Today, ISM devices are completely disallowed for vfio-pci passthrough as QEMU rejects the device due to an (inappropriate) MSI

Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-20 Thread Pierre Morel
On 1/20/21 3:03 PM, Matthew Rosato wrote: On 1/20/21 4:12 AM, Pierre Morel wrote: On 1/19/21 9:44 PM, Matthew Rosato wrote: Today, ISM devices are completely disallowed for vfio-pci passthrough as QEMU rejects the device due to an (inappropriate) MSI-X check.  Removing this fence, however,

Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-20 Thread Matthew Rosato
On 1/20/21 4:12 AM, Pierre Morel wrote: On 1/19/21 9:44 PM, Matthew Rosato wrote: Today, ISM devices are completely disallowed for vfio-pci passthrough as QEMU rejects the device due to an (inappropriate) MSI-X check.  Removing this fence, however, reveals additional deficiencies in the s390x

Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-20 Thread Pierre Morel
On 1/19/21 9:44 PM, Matthew Rosato wrote: Today, ISM devices are completely disallowed for vfio-pci passthrough as QEMU rejects the device due to an (inappropriate) MSI-X check. Removing this fence, however, reveals additional deficiencies in the s390x PCI interception layer that prevent ISM

[PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-19 Thread Matthew Rosato
Today, ISM devices are completely disallowed for vfio-pci passthrough as QEMU rejects the device due to an (inappropriate) MSI-X check. Removing this fence, however, reveals additional deficiencies in the s390x PCI interception layer that prevent ISM devices from working correctly. Namely, ISM blo