Re: [PATCH 01/10] mac_newworld: Drop some variables

2022-09-25 Thread Mark Cave-Ayland
On 17/09/2022 00:07, BALATON Zoltan wrote: Values not used frequently enough may not worth putting in a local variable, especially with names almost as long as the original value because that does not improve readability, to the contrary it makes it harder to see what value is used. Drop a few

Re: [PATCH 01/10] mac_newworld: Drop some variables

2022-09-17 Thread Philippe Mathieu-Daudé via
On 17/9/22 01:07, BALATON Zoltan wrote: Values not used frequently enough may not worth putting in a local variable, especially with names almost as long as the original value because that does not improve readability, to the contrary it makes it harder to see what value is used. Drop a few such

[PATCH 01/10] mac_newworld: Drop some variables

2022-09-16 Thread BALATON Zoltan
Values not used frequently enough may not worth putting in a local variable, especially with names almost as long as the original value because that does not improve readability, to the contrary it makes it harder to see what value is used. Drop a few such variables. This is the same clean up that