Re: [PATCH 01/10] migration-test: Create cmd_soure and cmd_target

2019-12-16 Thread Juan Quintela
Paolo Bonzini wrote: > On 12/12/19 23:20, Juan Quintela wrote: >> @@ -584,16 +585,16 @@ static int test_migrate_start(QTestState >> **from, QTestState **to, >> cmd_src = g_strdup_printf("-machine accel=%s -m 150M" > > There will be conflicts here as this "-machine accel=%s" will change to

Re: [PATCH 01/10] migration-test: Create cmd_soure and cmd_target

2019-12-16 Thread Paolo Bonzini
On 12/12/19 23:20, Juan Quintela wrote: > @@ -584,16 +585,16 @@ static int test_migrate_start(QTestState **from, > QTestState **to, > cmd_src = g_strdup_printf("-machine accel=%s -m 150M" There will be conflicts here as this "-machine accel=%s" will change to "-accel", but nothing major.

[PATCH 01/10] migration-test: Create cmd_soure and cmd_target

2019-12-12 Thread Juan Quintela
We are repeating almost everything for each machine while creating the command line for migration. And once for source and another for destination. We start putting there opts_src and opts_dst. Signed-off-by: Juan Quintela --- tests/migration-test.c | 44 ---