Re: [PATCH 01/19] configure: add --enable-tsan flag + fiber annotations for coroutine-ucontext

2020-06-17 Thread Robert Foley
Hi, On Wed, 17 Jun 2020 at 10:24, Stefan Hajnoczi wrote: > > On Fri, May 22, 2020 at 12:07:37PM -0400, Robert Foley wrote: > > +#define UC_DEBUG 0 > > +#if UC_DEBUG && defined(CONFIG_TSAN) > > +#define UC_TRACE(fmt, ...) fprintf(stderr, "%s:%d:%p " fmt "\n", \ > > +__func__, __LINE__,

Re: [PATCH 01/19] configure: add --enable-tsan flag + fiber annotations for coroutine-ucontext

2020-06-17 Thread Alex Bennée
Stefan Hajnoczi writes: > On Fri, May 22, 2020 at 12:07:37PM -0400, Robert Foley wrote: >> +#define UC_DEBUG 0 >> +#if UC_DEBUG && defined(CONFIG_TSAN) >> +#define UC_TRACE(fmt, ...) fprintf(stderr, "%s:%d:%p " fmt "\n", \ >> +__func__, __LINE__, __tsan_get_current_fiber(), ##__VA_ARGS__);

Re: [PATCH 01/19] configure: add --enable-tsan flag + fiber annotations for coroutine-ucontext

2020-06-17 Thread Stefan Hajnoczi
On Fri, May 22, 2020 at 12:07:37PM -0400, Robert Foley wrote: > +#define UC_DEBUG 0 > +#if UC_DEBUG && defined(CONFIG_TSAN) > +#define UC_TRACE(fmt, ...) fprintf(stderr, "%s:%d:%p " fmt "\n", \ > +__func__, __LINE__, __tsan_get_current_fiber(), ##__VA_ARGS__); > +#else > +#define UC_TRACE(fmt,

Re: [PATCH 01/19] configure: add --enable-tsan flag + fiber annotations for coroutine-ucontext

2020-05-26 Thread Robert Foley
On Sat, 23 May 2020 at 12:55, Philippe Mathieu-Daudé wrote: > > Hi Robert, > > On 5/22/20 6:07 PM, Robert Foley wrote: > > From: Lingfeng Yang > > > > We tried running QEMU under tsan in 2016, but tsan's lack of support for > > longjmp-based fibers was a blocker: > > @@ -6277,6 +6304,14 @@ if

Re: [PATCH 01/19] configure: add --enable-tsan flag + fiber annotations for coroutine-ucontext

2020-05-23 Thread Philippe Mathieu-Daudé
Hi Robert, On 5/22/20 6:07 PM, Robert Foley wrote: > From: Lingfeng Yang > > We tried running QEMU under tsan in 2016, but tsan's lack of support for > longjmp-based fibers was a blocker: > https://groups.google.com/forum/#!topic/thread-sanitizer/se0YuzfWazw > > Fortunately, thread sanitizer

[PATCH 01/19] configure: add --enable-tsan flag + fiber annotations for coroutine-ucontext

2020-05-22 Thread Robert Foley
From: Lingfeng Yang We tried running QEMU under tsan in 2016, but tsan's lack of support for longjmp-based fibers was a blocker: https://groups.google.com/forum/#!topic/thread-sanitizer/se0YuzfWazw Fortunately, thread sanitizer gained fiber support in early 2019: