Re: [PATCH 01/26] block: remove incorrect coroutine_fn annotations

2022-04-21 Thread Stefan Hajnoczi
On Tue, Apr 19, 2022 at 12:57:54PM -0500, Eric Blake wrote: > On Fri, Apr 15, 2022 at 03:18:35PM +0200, Paolo Bonzini wrote: > > Signed-off-by: Paolo Bonzini > > Might be nice to document in the commit message why the annotation was > incorrect, so someone stumbling across this commit in a

Re: [PATCH 01/26] block: remove incorrect coroutine_fn annotations

2022-04-19 Thread Eric Blake
On Fri, Apr 15, 2022 at 03:18:35PM +0200, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini Might be nice to document in the commit message why the annotation was incorrect, so someone stumbling across this commit in a bisect but otherwise unfamiliar with the rules of when to annotate doesn't

[PATCH 01/26] block: remove incorrect coroutine_fn annotations

2022-04-15 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/block-backend.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/block-backend.c b/block/block-backend.c index e0e1aff4b1..fedf2eca83 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@ -1391,10 +1391,10 @@ int