Re: [PATCH 04/10] spice: Move all the spice-related code in spice-app.so

2020-06-29 Thread Gerd Hoffmann
Hi, > common-obj-y = audio.o audio_legacy.o noaudio.o wavaudio.o mixeng.o > -common-obj-$(CONFIG_SPICE) += spiceaudio.o > +spice-app.mo-objs += ../audio/spiceaudio.o Hmm. audio/audio.c will try to load audio-${backend}.so when you run qemu -audiodev ${backend}, so I suspect this is not going

Re: [PATCH 04/10] spice: Move all the spice-related code in spice-app.so

2020-06-29 Thread Daniel P . Berrangé
On Mon, Jun 29, 2020 at 11:22:40AM +0200, Christophe de Dinechin wrote: > > On 2020-06-26 at 19:20 CEST, Daniel P. Berrangé wrote... > > On Fri, Jun 26, 2020 at 06:43:01PM +0200, Christophe de Dinechin wrote: > >> If we want to build spice as a separately loadable module, we need to > >> put all t

Re: [PATCH 04/10] spice: Move all the spice-related code in spice-app.so

2020-06-29 Thread Christophe de Dinechin
On 2020-06-26 at 19:20 CEST, Daniel P. Berrangé wrote... > On Fri, Jun 26, 2020 at 06:43:01PM +0200, Christophe de Dinechin wrote: >> If we want to build spice as a separately loadable module, we need to >> put all the spice code in one loadable module, because the build >> system does not know h

Re: [PATCH 04/10] spice: Move all the spice-related code in spice-app.so

2020-06-26 Thread Daniel P . Berrangé
On Fri, Jun 26, 2020 at 06:43:01PM +0200, Christophe de Dinechin wrote: > If we want to build spice as a separately loadable module, we need to > put all the spice code in one loadable module, because the build > system does not know how to deal with dependencies yet. > > Signed-off-by: Christophe

[PATCH 04/10] spice: Move all the spice-related code in spice-app.so

2020-06-26 Thread Christophe de Dinechin
If we want to build spice as a separately loadable module, we need to put all the spice code in one loadable module, because the build system does not know how to deal with dependencies yet. Signed-off-by: Christophe de Dinechin --- audio/Makefile.objs | 2 +- chardev/Makefile.objs | 3 +-- ui