Re: [PATCH 05/14] target/arm: Simplify register counting in arm_gen_dynamic_svereg_xml

2023-02-14 Thread Richard Henderson
On 2/14/23 09:42, Fabiano Rosas wrote: @@ -310,8 +313,8 @@ int arm_gen_dynamic_svereg_xml(CPUState *cs, int base_reg) g_string_append_printf(s, "", base_reg++); -info->num += 2; +/* Define the predicate registers. */ for (i = 0; i < 16; i++) { There's a info->num++; at

Re: [PATCH 05/14] target/arm: Simplify register counting in arm_gen_dynamic_svereg_xml

2023-02-14 Thread Fabiano Rosas
Richard Henderson writes: > Rather than increment base_reg and num, compute num > from the change to base_reg at the end. Clean up some > nearby comments. > > Signed-off-by: Richard Henderson > --- > target/arm/gdbstub64.c | 26 -- > 1 file changed, 16 insertions(+),

[PATCH 05/14] target/arm: Simplify register counting in arm_gen_dynamic_svereg_xml

2023-02-14 Thread Richard Henderson
Rather than increment base_reg and num, compute num from the change to base_reg at the end. Clean up some nearby comments. Signed-off-by: Richard Henderson --- target/arm/gdbstub64.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git