Re: [PATCH 05/18] vfio/common: Add VFIOBitmap and (de)alloc functions

2023-02-14 Thread Alex Williamson
On Sun, 12 Feb 2023 17:36:49 +0200 Avihai Horon wrote: > On 27/01/2023 23:11, Alex Williamson wrote: > > External email: Use caution opening links or attachments > > > > > > On Thu, 26 Jan 2023 20:49:35 +0200 > > Avihai Horon wrote: > > > >> There are already two places where dirty page bitmap

Re: [PATCH 05/18] vfio/common: Add VFIOBitmap and (de)alloc functions

2023-02-12 Thread Avihai Horon
On 27/01/2023 23:11, Alex Williamson wrote: External email: Use caution opening links or attachments On Thu, 26 Jan 2023 20:49:35 +0200 Avihai Horon wrote: There are already two places where dirty page bitmap allocation and calculations are done in open code. With device dirty page trackin

Re: [PATCH 05/18] vfio/common: Add VFIOBitmap and (de)alloc functions

2023-01-27 Thread Alex Williamson
On Thu, 26 Jan 2023 20:49:35 +0200 Avihai Horon wrote: > There are already two places where dirty page bitmap allocation and > calculations are done in open code. With device dirty page tracking > being added in next patches, there are going to be even more places. > > To avoid code duplication,

[PATCH 05/18] vfio/common: Add VFIOBitmap and (de)alloc functions

2023-01-26 Thread Avihai Horon
There are already two places where dirty page bitmap allocation and calculations are done in open code. With device dirty page tracking being added in next patches, there are going to be even more places. To avoid code duplication, introduce VFIOBitmap struct and corresponding alloc and dealloc fu