Re: [PATCH 06/14] hw/i386/vmport: Define enum for all commands

2020-03-10 Thread Liran Alon
On 10/03/2020 13:46, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 01:37:40PM +0200, Liran Alon wrote: On 10/03/2020 13:23, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 01:16:51PM +0200, Liran Alon wrote: On 10/03/2020 11:28, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at

Re: [PATCH 06/14] hw/i386/vmport: Define enum for all commands

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 01:37:40PM +0200, Liran Alon wrote: > > On 10/03/2020 13:23, Michael S. Tsirkin wrote: > > On Tue, Mar 10, 2020 at 01:16:51PM +0200, Liran Alon wrote: > > > On 10/03/2020 11:28, Michael S. Tsirkin wrote: > > > > On Tue, Mar 10, 2020 at 01:54:03AM +0200, Liran Alon wrote: >

Re: [PATCH 06/14] hw/i386/vmport: Define enum for all commands

2020-03-10 Thread Liran Alon
On 10/03/2020 13:23, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 01:16:51PM +0200, Liran Alon wrote: On 10/03/2020 11:28, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 01:54:03AM +0200, Liran Alon wrote: No functional change. Defining an enum for all VMPort commands have the

Re: [PATCH 06/14] hw/i386/vmport: Define enum for all commands

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 01:16:51PM +0200, Liran Alon wrote: > > On 10/03/2020 11:28, Michael S. Tsirkin wrote: > > On Tue, Mar 10, 2020 at 01:54:03AM +0200, Liran Alon wrote: > > > No functional change. > > > > > > Defining an enum for all VMPort commands have the following advantages: > > > *

Re: [PATCH 06/14] hw/i386/vmport: Define enum for all commands

2020-03-10 Thread Liran Alon
On 10/03/2020 11:28, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 01:54:03AM +0200, Liran Alon wrote: No functional change. Defining an enum for all VMPort commands have the following advantages: * It gets rid of the error-prone requirement to update VMPORT_ENTRIES when new VMPort

Re: [PATCH 06/14] hw/i386/vmport: Define enum for all commands

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 01:54:03AM +0200, Liran Alon wrote: > No functional change. > > Defining an enum for all VMPort commands have the following advantages: > * It gets rid of the error-prone requirement to update VMPORT_ENTRIES > when new VMPort commands are added to QEMU. > * It makes it

[PATCH 06/14] hw/i386/vmport: Define enum for all commands

2020-03-09 Thread Liran Alon
No functional change. Defining an enum for all VMPort commands have the following advantages: * It gets rid of the error-prone requirement to update VMPORT_ENTRIES when new VMPort commands are added to QEMU. * It makes it clear to know by looking at one place at the source, what are all the