Re: [PATCH 06/26] blkdebug: add missing coroutine_fn annotations

2022-10-06 Thread Kevin Wolf
Am 05.10.2022 um 23:11 hat Paolo Bonzini geschrieben: > Il mer 5 ott 2022, 06:32 Kevin Wolf ha scritto: > > > Hm... blkdebug_debug_event() is called from bdrv_debug_event(), which is > > not coroutine_fn. And I think that it's not coroutine_fn is correct: > > For example, with 'qemu-img snapshot

Re: [PATCH 06/26] blkdebug: add missing coroutine_fn annotations

2022-10-05 Thread Paolo Bonzini
Il mer 5 ott 2022, 06:32 Kevin Wolf ha scritto: > Hm... blkdebug_debug_event() is called from bdrv_debug_event(), which is > not coroutine_fn. And I think that it's not coroutine_fn is correct: > For example, with 'qemu-img snapshot -c' you get img_snapshot() -> > bdrv_snapshot_create() ->

Re: [PATCH 06/26] blkdebug: add missing coroutine_fn annotations

2022-10-05 Thread Kevin Wolf
Am 22.09.2022 um 10:49 hat Paolo Bonzini geschrieben: > Callers of coroutine_fn must be coroutine_fn themselves, or the call > must be within "if (qemu_in_coroutine())". Apply coroutine_fn to > functions where this holds. > > Reviewed-by: Alberto Faria > Reviewed-by: Eric Blake >

[PATCH 06/26] blkdebug: add missing coroutine_fn annotations

2022-09-22 Thread Paolo Bonzini
Callers of coroutine_fn must be coroutine_fn themselves, or the call must be within "if (qemu_in_coroutine())". Apply coroutine_fn to functions where this holds. Reviewed-by: Alberto Faria Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini --- block/blkdebug.c | 14 +++--- 1 file