Re: [PATCH 06/37] qapi: delint using flake8

2020-09-21 Thread John Snow
On 9/21/20 3:31 AM, Markus Armbruster wrote: John Snow writes: On 9/18/20 6:33 AM, Markus Armbruster wrote: John Snow writes: [...] 2. Writing a templating engine that doesn't break the Python indentation flow by hoisting them into module constants and improving the rendering logic.

Re: [PATCH 06/37] qapi: delint using flake8

2020-09-21 Thread Markus Armbruster
John Snow writes: > On 9/18/20 6:33 AM, Markus Armbruster wrote: >> John Snow writes: [...] >>> Embedded templates are always gonna look kinda nasty, I think, because >>> you're trying to fight style guidelines in two languages >>> simultaneously and it's never gonna quite work out exactly how

Re: [PATCH 06/37] qapi: delint using flake8

2020-09-18 Thread John Snow
On 9/18/20 6:33 AM, Markus Armbruster wrote: John Snow writes: On 9/17/20 3:54 AM, Markus Armbruster wrote: John Snow writes: On 9/16/20 8:12 AM, Markus Armbruster wrote: John Snow writes: Petty style guide fixes and line length enforcement. Not a big win, not a big loss, but flake8

Re: [PATCH 06/37] qapi: delint using flake8

2020-09-18 Thread Markus Armbruster
John Snow writes: > On 9/17/20 3:54 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 9/16/20 8:12 AM, Markus Armbruster wrote: John Snow writes: > Petty style guide fixes and line length enforcement. Not a big win, not > a big loss, but flake8 passes 100% on the

Re: [PATCH 06/37] qapi: delint using flake8

2020-09-17 Thread John Snow
On 9/17/20 3:54 AM, Markus Armbruster wrote: John Snow writes: On 9/16/20 8:12 AM, Markus Armbruster wrote: John Snow writes: Petty style guide fixes and line length enforcement. Not a big win, not a big loss, but flake8 passes 100% on the qapi module, which gives us an easy baseline to

Re: [PATCH 06/37] qapi: delint using flake8

2020-09-17 Thread Markus Armbruster
John Snow writes: > On 9/16/20 8:12 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Petty style guide fixes and line length enforcement. Not a big win, not >>> a big loss, but flake8 passes 100% on the qapi module, which gives us an >>> easy baseline to enforce hereafter. >>> >>>

Re: [PATCH 06/37] qapi: delint using flake8

2020-09-16 Thread John Snow
On 9/16/20 8:12 AM, Markus Armbruster wrote: John Snow writes: Petty style guide fixes and line length enforcement. Not a big win, not a big loss, but flake8 passes 100% on the qapi module, which gives us an easy baseline to enforce hereafter. Signed-off-by: John Snow ---

Re: [PATCH 06/37] qapi: delint using flake8

2020-09-16 Thread Markus Armbruster
John Snow writes: > Petty style guide fixes and line length enforcement. Not a big win, not > a big loss, but flake8 passes 100% on the qapi module, which gives us an > easy baseline to enforce hereafter. > > Signed-off-by: John Snow > --- > scripts/qapi/.flake8 | 2 ++ >

[PATCH 06/37] qapi: delint using flake8

2020-09-15 Thread John Snow
Petty style guide fixes and line length enforcement. Not a big win, not a big loss, but flake8 passes 100% on the qapi module, which gives us an easy baseline to enforce hereafter. Signed-off-by: John Snow --- scripts/qapi/.flake8 | 2 ++ scripts/qapi/commands.py | 3 ++-