Re: [PATCH 072/104] virtiofsd: passthrough_ll: fix refcounting on remove/rename

2020-01-20 Thread Dr. David Alan Gilbert
* Sergio Lopez (s...@redhat.com) wrote: > > Dr. David Alan Gilbert (git) writes: > > > From: Miklos Szeredi > > > > Signed-off-by: Miklos Szeredi > > --- > > tools/virtiofsd/passthrough_ll.c | 50 +++- > > 1 file changed, 49 insertions(+), 1 deletion(-) > > This o

Re: [PATCH 072/104] virtiofsd: passthrough_ll: fix refcounting on remove/rename

2020-01-20 Thread Sergio Lopez
Dr. David Alan Gilbert (git) writes: > From: Miklos Szeredi > > Signed-off-by: Miklos Szeredi > --- > tools/virtiofsd/passthrough_ll.c | 50 +++- > 1 file changed, 49 insertions(+), 1 deletion(-) This one is missing a commit message, and I think the patch isn't tr

Re: [PATCH 072/104] virtiofsd: passthrough_ll: fix refcounting on remove/rename

2020-01-17 Thread Dr. David Alan Gilbert
* Miklos Szeredi (mszer...@redhat.com) wrote: > On Thu, Jan 16, 2020 at 5:45 PM Dr. David Alan Gilbert > wrote: > > > > * Misono Tomohiro (misono.tomoh...@jp.fujitsu.com) wrote: > > > > From: Miklos Szeredi > > > > > > > > Signed-off-by: Miklos Szeredi > > > > > > I'm not familiar with qemu conv

Re: [PATCH 072/104] virtiofsd: passthrough_ll: fix refcounting on remove/rename

2020-01-17 Thread Dr. David Alan Gilbert
* Miklos Szeredi (mszer...@redhat.com) wrote: > On Thu, Jan 16, 2020 at 5:45 PM Dr. David Alan Gilbert > wrote: > > > > * Misono Tomohiro (misono.tomoh...@jp.fujitsu.com) wrote: > > > > From: Miklos Szeredi > > > > > > > > Signed-off-by: Miklos Szeredi > > > > > > I'm not familiar with qemu conv

Re: [PATCH 072/104] virtiofsd: passthrough_ll: fix refcounting on remove/rename

2020-01-17 Thread Miklos Szeredi
On Thu, Jan 16, 2020 at 5:45 PM Dr. David Alan Gilbert wrote: > > * Misono Tomohiro (misono.tomoh...@jp.fujitsu.com) wrote: > > > From: Miklos Szeredi > > > > > > Signed-off-by: Miklos Szeredi > > > > I'm not familiar with qemu convention but shouldn't we put > > at least one line of description

Re: [PATCH 072/104] virtiofsd: passthrough_ll: fix refcounting on remove/rename

2020-01-16 Thread Dr. David Alan Gilbert
* Misono Tomohiro (misono.tomoh...@jp.fujitsu.com) wrote: > > From: Miklos Szeredi > > > > Signed-off-by: Miklos Szeredi > > I'm not familiar with qemu convention but shouldn't we put > at least one line of description like linux kernel? Miklos: would you like to suggest a better commit messag

Re: [PATCH 072/104] virtiofsd: passthrough_ll: fix refcounting on remove/rename

2020-01-16 Thread Misono Tomohiro
> From: Miklos Szeredi > > Signed-off-by: Miklos Szeredi I'm not familiar with qemu convention but shouldn't we put at least one line of description like linux kernel? For code itself: Reviewed-by: Misono Tomohiro > --- > tools/virtiofsd/passthrough_ll.c | 50 ++

[PATCH 072/104] virtiofsd: passthrough_ll: fix refcounting on remove/rename

2019-12-12 Thread Dr. David Alan Gilbert (git)
From: Miklos Szeredi Signed-off-by: Miklos Szeredi --- tools/virtiofsd/passthrough_ll.c | 50 +++- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c index 0f33c3c5e9..1b84d4f313 100644 --