Re: [PATCH 1/1] vhost-vsock: add VIRTIO_F_RING_PACKED to feaure_bits

2024-06-03 Thread Halil Pasic
On Thu, 30 May 2024 10:34:55 +0800 Jason Wang wrote: > > > > IMHO changing the semantic of the VHOST_GET_FEATURES ioctl is not viable, > > but also not necessary. What I am proposing is changing the (in QEMU) > > logic of processing the features returned by VHOST_GET_FEATURES, while > >

Re: [PATCH 1/1] vhost-vsock: add VIRTIO_F_RING_PACKED to feaure_bits

2024-05-30 Thread Stefano Garzarella
On Wed, May 29, 2024 at 02:49:28PM GMT, Halil Pasic wrote: On Tue, 28 May 2024 17:32:26 +0200 Stefano Garzarella wrote: >1) The uses is explicitly asking for a vhost device and giving the user >a non vhost device is not an option. I didn't get this point :-( can you elaborate? I was

Re: [PATCH 1/1] vhost-vsock: add VIRTIO_F_RING_PACKED to feaure_bits

2024-05-29 Thread Jason Wang
On Wed, May 29, 2024 at 8:18 PM Halil Pasic wrote: > > On Tue, 28 May 2024 11:25:51 +0800 > Jason Wang wrote: > > > > 5) Based on the following, I would very much prefer a per device list of > > > features with the semantic "hey QEMU can do that feature without any > > > specialized vhost-device

Re: [PATCH 1/1] vhost-vsock: add VIRTIO_F_RING_PACKED to feaure_bits

2024-05-29 Thread Halil Pasic
On Tue, 28 May 2024 17:32:26 +0200 Stefano Garzarella wrote: > >1) The uses is explicitly asking for a vhost device and giving the user > >a non vhost device is not an option. > > I didn't get this point :-( can you elaborate? I was thinking along the lines: QEMU gets told what devices to

Re: [PATCH 1/1] vhost-vsock: add VIRTIO_F_RING_PACKED to feaure_bits

2024-05-29 Thread Halil Pasic
On Tue, 28 May 2024 11:25:51 +0800 Jason Wang wrote: > > 5) Based on the following, I would very much prefer a per device list of > > features with the semantic "hey QEMU can do that feature without any > > specialized vhost-device support (e.g. like VIRTIO_SCSI_F_CHANGE)" > > Indeed the

Re: [PATCH 1/1] vhost-vsock: add VIRTIO_F_RING_PACKED to feaure_bits

2024-05-28 Thread Stefano Garzarella
On Mon, May 27, 2024 at 01:27:10PM GMT, Halil Pasic wrote: On Thu, 16 May 2024 10:39:42 +0200 Stefano Garzarella wrote: [..] >--- > >This is a minimal fix, that follows the current patterns in the >codebase, and not necessarily the best one. Yeah, I did something similar with commit

Re: [PATCH 1/1] vhost-vsock: add VIRTIO_F_RING_PACKED to feaure_bits

2024-05-27 Thread Jason Wang
On Mon, May 27, 2024 at 7:27 PM Halil Pasic wrote: > > On Thu, 16 May 2024 10:39:42 +0200 > Stefano Garzarella wrote: > > [..] > > >--- > > > > > >This is a minimal fix, that follows the current patterns in the > > >codebase, and not necessarily the best one. > > > > Yeah, I did something

Re: [PATCH 1/1] vhost-vsock: add VIRTIO_F_RING_PACKED to feaure_bits

2024-05-27 Thread Halil Pasic
On Thu, 16 May 2024 10:39:42 +0200 Stefano Garzarella wrote: [..] > >--- > > > >This is a minimal fix, that follows the current patterns in the > >codebase, and not necessarily the best one. > > Yeah, I did something similar with commit 562a7d23bf ("vhost: mask > VIRTIO_F_RING_RESET for

Re: [PATCH 1/1] vhost-vsock: add VIRTIO_F_RING_PACKED to feaure_bits

2024-05-16 Thread Stefano Garzarella
On Mon, Apr 29, 2024 at 01:33:34PM GMT, Halil Pasic wrote: Not having VIRTIO_F_RING_PACKED in feature_bits[] is a problem when the vhost-vsock device does not offer the feature bit VIRTIO_F_RING_PACKED but the in QEMU device is configured to try to use the packed layout (the virtio property

Re: [PATCH 1/1] vhost-vsock: add VIRTIO_F_RING_PACKED to feaure_bits

2024-05-15 Thread Halil Pasic
On Tue, 7 May 2024 21:26:30 +0200 Halil Pasic wrote: > > Not having VIRTIO_F_RING_PACKED in feature_bits[] is a problem when the > > vhost-vsock device does not offer the feature bit VIRTIO_F_RING_PACKED > > but the in QEMU device is configured to try to use the packed layout > > (the virtio

Re: [PATCH 1/1] vhost-vsock: add VIRTIO_F_RING_PACKED to feaure_bits

2024-05-07 Thread Halil Pasic
On Mon, 29 Apr 2024 13:33:34 +0200 Halil Pasic wrote: > Not having VIRTIO_F_RING_PACKED in feature_bits[] is a problem when the > vhost-vsock device does not offer the feature bit VIRTIO_F_RING_PACKED > but the in QEMU device is configured to try to use the packed layout > (the virtio property

[PATCH 1/1] vhost-vsock: add VIRTIO_F_RING_PACKED to feaure_bits

2024-04-29 Thread Halil Pasic
Not having VIRTIO_F_RING_PACKED in feature_bits[] is a problem when the vhost-vsock device does not offer the feature bit VIRTIO_F_RING_PACKED but the in QEMU device is configured to try to use the packed layout (the virtio property "packed" is on). As of today, the Linux kernel vhost-vsock