Re: [PATCH 1/2] hw/core/machine: Split out smp_parse as an inline API

2021-10-12 Thread wangyanan (Y)
On 2021/10/12 22:36, Markus Armbruster wrote: "wangyanan (Y)" writes: Hi Markus, On 2021/10/11 13:26, Markus Armbruster wrote: Yanan Wang writes: Functionally smp_parse() is only called once and in one place i.e. machine_set_smp, the possible second place where it'll be called should

Re: [PATCH 1/2] hw/core/machine: Split out smp_parse as an inline API

2021-10-12 Thread Markus Armbruster
"wangyanan (Y)" writes: > Hi Markus, > > On 2021/10/11 13:26, Markus Armbruster wrote: >> Yanan Wang writes: >> >>> Functionally smp_parse() is only called once and in one place >>> i.e. machine_set_smp, the possible second place where it'll be >>> called should be some unit tests if any. >>>

Re: [PATCH 1/2] hw/core/machine: Split out smp_parse as an inline API

2021-10-11 Thread wangyanan (Y)
Hi Markus, On 2021/10/11 13:26, Markus Armbruster wrote: Yanan Wang writes: Functionally smp_parse() is only called once and in one place i.e. machine_set_smp, the possible second place where it'll be called should be some unit tests if any. Actually we are going to introduce an unit test

Re: [PATCH 1/2] hw/core/machine: Split out smp_parse as an inline API

2021-10-10 Thread Markus Armbruster
Yanan Wang writes: > Functionally smp_parse() is only called once and in one place > i.e. machine_set_smp, the possible second place where it'll be > called should be some unit tests if any. > > Actually we are going to introduce an unit test for the parser. > For necessary isolation of the

[PATCH 1/2] hw/core/machine: Split out smp_parse as an inline API

2021-10-10 Thread Yanan Wang
Functionally smp_parse() is only called once and in one place i.e. machine_set_smp, the possible second place where it'll be called should be some unit tests if any. Actually we are going to introduce an unit test for the parser. For necessary isolation of the tested code, split smp_parse out