Re: [PATCH 1/2] keyval: accept escaped commas in implied option

2020-11-27 Thread Paolo Bonzini
On 27/11/20 15:39, Markus Armbruster wrote: Nah, just lazy cut-and-paste of the existing error message. I should rename that error to something "No implicit parameter name for '.key'" (again, different grammar -> different parser -> different error). That error message actually makes sense:

Re: [PATCH 1/2] keyval: accept escaped commas in implied option

2020-11-27 Thread Markus Armbruster
Paolo Bonzini writes: > [huge snip] > > On 27/11/20 09:38, Markus Armbruster wrote: >> The suboptimal error message is due to the way I coded the parser, not >> due to the grammar. > > Small digression: a different grammar influences how the parser is > written. You coded the parser like this

Re: [PATCH 1/2] keyval: accept escaped commas in implied option

2020-11-27 Thread Paolo Bonzini
[huge snip] On 27/11/20 09:38, Markus Armbruster wrote: The suboptimal error message is due to the way I coded the parser, not due to the grammar. Small digression: a different grammar influences how the parser is written. You coded the parser like this because you thought of implied

Re: [PATCH 1/2] keyval: accept escaped commas in implied option

2020-11-27 Thread Markus Armbruster
Paolo Bonzini writes: > This is used with the weirdly-named device "SUNFD,two", so accepting it "SUNW,fdtwo" > is also a preparatory step towards keyval-ifying -device and the > device_add monitor command. Not quite. Device "SUNW,fdtwo" has user_creatable = false (it's a sysbus device), and

Re: [PATCH 1/2] keyval: accept escaped commas in implied option

2020-11-11 Thread Mark Cave-Ayland
On 11/11/2020 10:53, Daniel P. Berrangé wrote: On Wed, Nov 11, 2020 at 05:45:20AM -0500, Paolo Bonzini wrote: This is used with the weirdly-named device "SUNFD,two", so accepting it is also a preparatory step towards keyval-ifying -device and the device_add monitor command. But in general it

Re: [PATCH 1/2] keyval: accept escaped commas in implied option

2020-11-11 Thread Paolo Bonzini
On 11/11/20 11:53, Daniel P. Berrangé wrote: On Wed, Nov 11, 2020 at 05:45:20AM -0500, Paolo Bonzini wrote: This is used with the weirdly-named device "SUNFD,two", so accepting it is also a preparatory step towards keyval-ifying -device and the device_add monitor command. But in general it is

Re: [PATCH 1/2] keyval: accept escaped commas in implied option

2020-11-11 Thread Daniel P . Berrangé
On Wed, Nov 11, 2020 at 05:45:20AM -0500, Paolo Bonzini wrote: > This is used with the weirdly-named device "SUNFD,two", so accepting it > is also a preparatory step towards keyval-ifying -device and the > device_add monitor command. But in general it is an unexpected wart > of the keyval syntax

[PATCH 1/2] keyval: accept escaped commas in implied option

2020-11-11 Thread Paolo Bonzini
This is used with the weirdly-named device "SUNFD,two", so accepting it is also a preparatory step towards keyval-ifying -device and the device_add monitor command. But in general it is an unexpected wart of the keyval syntax and leads to suboptimal errors compared to QemuOpts: $