Re: [PATCH 1/2] misc/pca9552: Fix inverted input status

2023-10-24 Thread Miles Glenn
On Tue, 2023-10-24 at 10:04 +1030, Andrew Jeffery wrote: > On Fri, 2023-10-20 at 11:32 -0500, Miles Glenn wrote: > > On Fri, 2023-10-20 at 11:42 +0200, Philippe Mathieu-Daudé wrote: > > > On 20/10/23 04:51, Andrew Jeffery wrote: > > > > On Thu, 2023-10-19 at 15:40 -0500, Glenn Miles wrote: > > > >

Re: [PATCH 1/2] misc/pca9552: Fix inverted input status

2023-10-23 Thread Andrew Jeffery
On Fri, 2023-10-20 at 11:32 -0500, Miles Glenn wrote: > On Fri, 2023-10-20 at 11:42 +0200, Philippe Mathieu-Daudé wrote: > > On 20/10/23 04:51, Andrew Jeffery wrote: > > > On Thu, 2023-10-19 at 15:40 -0500, Glenn Miles wrote: > > > > > The pca9552 INPUT0 and INPUT1 registers are supposed to > > >

Re: [PATCH 1/2] misc/pca9552: Fix inverted input status

2023-10-20 Thread Miles Glenn
On Fri, 2023-10-20 at 11:42 +0200, Philippe Mathieu-Daudé wrote: > On 20/10/23 04:51, Andrew Jeffery wrote: > > On Thu, 2023-10-19 at 15:40 -0500, Glenn Miles wrote: > > > > The pca9552 INPUT0 and INPUT1 registers are supposed to > > > > hold the logical values of the LED pins. A logical 0 > > >

Re: [PATCH 1/2] misc/pca9552: Fix inverted input status

2023-10-20 Thread Philippe Mathieu-Daudé
On 20/10/23 04:51, Andrew Jeffery wrote: On Thu, 2023-10-19 at 15:40 -0500, Glenn Miles wrote: The pca9552 INPUT0 and INPUT1 registers are supposed to hold the logical values of the LED pins. A logical 0 should be seen in the INPUT0/1 registers for a pin when its corresponding LSn bits are set

Re: [PATCH 1/2] misc/pca9552: Fix inverted input status

2023-10-19 Thread Andrew Jeffery
On Thu, 2023-10-19 at 15:40 -0500, Glenn Miles wrote: > > The pca9552 INPUT0 and INPUT1 registers are supposed to > > hold the logical values of the LED pins. A logical 0 > > should be seen in the INPUT0/1 registers for a pin when > > its corresponding LSn bits are set to 0, which is also > > the

[PATCH 1/2] misc/pca9552: Fix inverted input status

2023-10-19 Thread Glenn Miles
The pca9552 INPUT0 and INPUT1 registers are supposed to hold the logical values of the LED pins. A logical 0 should be seen in the INPUT0/1 registers for a pin when its corresponding LSn bits are set to 0, which is also the state needed for turning on an LED in a typical usage scenario. Existing