Re: [PATCH 1/2] python: introduce qmp-shell-wrap convenience tool

2022-01-20 Thread John Snow
On Thu, Jan 20, 2022 at 8:40 AM Daniel P. Berrangé wrote: > > On Thu, Jan 20, 2022 at 02:33:46PM +0100, Philippe Mathieu-Daudé wrote: > > On 18/1/22 19:04, John Snow wrote: > > > On Tue, Jan 18, 2022 at 5:06 AM Daniel P. Berrangé > > > wrote: > > > > > > It would be nice to just have this integr

Re: [PATCH 1/2] python: introduce qmp-shell-wrap convenience tool

2022-01-20 Thread Beraldo Leal
On Tue, Jan 18, 2022 at 06:13:48AM +0100, Philippe Mathieu-Daudé wrote: > On 18/1/22 00:27, John Snow wrote: > > On Mon, Jan 17, 2022 at 9:11 AM Daniel P. Berrangé > > wrote: > > > > > > With the current 'qmp-shell' tool developers must first spawn QEMU with > > > a suitable -qmp arg and then sp

Re: [PATCH 1/2] python: introduce qmp-shell-wrap convenience tool

2022-01-20 Thread Daniel P . Berrangé
On Thu, Jan 20, 2022 at 02:33:46PM +0100, Philippe Mathieu-Daudé wrote: > On 18/1/22 19:04, John Snow wrote: > > On Tue, Jan 18, 2022 at 5:06 AM Daniel P. Berrangé > > wrote: > > > > It would be nice to just have this integrated into 'make check' so we > > > don't need to remember to run a speci

Re: [PATCH 1/2] python: introduce qmp-shell-wrap convenience tool

2022-01-20 Thread Philippe Mathieu-Daudé via
On 18/1/22 19:04, John Snow wrote: On Tue, Jan 18, 2022 at 5:06 AM Daniel P. Berrangé wrote: It would be nice to just have this integrated into 'make check' so we don't need to remember to run a special command. The CI will run it, but 'make check' doesn't. To add it to make check, I need t

Re: [PATCH 1/2] python: introduce qmp-shell-wrap convenience tool

2022-01-18 Thread John Snow
On Tue, Jan 18, 2022 at 5:06 AM Daniel P. Berrangé wrote: > > On Mon, Jan 17, 2022 at 06:27:24PM -0500, John Snow wrote: > > On Mon, Jan 17, 2022 at 9:11 AM Daniel P. Berrangé > > wrote: > > > > > > With the current 'qmp-shell' tool developers must first spawn QEMU with > > > a suitable -qmp arg

Re: [PATCH 1/2] python: introduce qmp-shell-wrap convenience tool

2022-01-18 Thread Daniel P . Berrangé
On Mon, Jan 17, 2022 at 06:27:24PM -0500, John Snow wrote: > On Mon, Jan 17, 2022 at 9:11 AM Daniel P. Berrangé > wrote: > > > > With the current 'qmp-shell' tool developers must first spawn QEMU with > > a suitable -qmp arg and then spawn qmp-shell in a separate terminal > > pointing to the righ

Re: [PATCH 1/2] python: introduce qmp-shell-wrap convenience tool

2022-01-17 Thread Philippe Mathieu-Daudé via
On 18/1/22 00:27, John Snow wrote: On Mon, Jan 17, 2022 at 9:11 AM Daniel P. Berrangé wrote: With the current 'qmp-shell' tool developers must first spawn QEMU with a suitable -qmp arg and then spawn qmp-shell in a separate terminal pointing to the right socket. With 'qmp-shell-wrap' develope

Re: [PATCH 1/2] python: introduce qmp-shell-wrap convenience tool

2022-01-17 Thread John Snow
On Mon, Jan 17, 2022 at 9:11 AM Daniel P. Berrangé wrote: > > With the current 'qmp-shell' tool developers must first spawn QEMU with > a suitable -qmp arg and then spawn qmp-shell in a separate terminal > pointing to the right socket. > > With 'qmp-shell-wrap' developers can ignore QMP sockets en

[PATCH 1/2] python: introduce qmp-shell-wrap convenience tool

2022-01-17 Thread Daniel P . Berrangé
With the current 'qmp-shell' tool developers must first spawn QEMU with a suitable -qmp arg and then spawn qmp-shell in a separate terminal pointing to the right socket. With 'qmp-shell-wrap' developers can ignore QMP sockets entirely and just pass the QEMU command and arguments they want. The pro