Re: [PATCH 1/2] target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules

2024-01-12 Thread Philippe Mathieu-Daudé
On 12/1/24 12:33, Cédric Le Goater wrote: On 1/12/24 11:55, Thomas Huth wrote: On 12/01/2024 06.21, Harsh Prateek Bora wrote: Hmm .. I would certainly vote for 'p' over 'plus'. Ok, I don't mind either way ... does anybody else have any preferences? p is fine. We also use 'p' for '+' /

Re: [PATCH 1/2] target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules

2024-01-12 Thread Cédric Le Goater
On 1/12/24 11:55, Thomas Huth wrote: On 12/01/2024 06.21, Harsh Prateek Bora wrote: On 1/12/24 10:42, Thomas Huth wrote: On 12/01/2024 05.57, Harsh Prateek Bora wrote: On 1/11/24 22:16, Thomas Huth wrote: The character "+" is now forbidden in QOM device names (see commit b447378e1217 -

Re: [PATCH 1/2] target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules

2024-01-12 Thread Thomas Huth
On 12/01/2024 06.21, Harsh Prateek Bora wrote: On 1/12/24 10:42, Thomas Huth wrote: On 12/01/2024 05.57, Harsh Prateek Bora wrote: On 1/11/24 22:16, Thomas Huth wrote: The character "+" is now forbidden in QOM device names (see commit b447378e1217 - "Limit type names to alphanumerical and

Re: [PATCH 1/2] target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules

2024-01-11 Thread Harsh Prateek Bora
On 1/12/24 10:42, Thomas Huth wrote: On 12/01/2024 05.57, Harsh Prateek Bora wrote: On 1/11/24 22:16, Thomas Huth wrote: The character "+" is now forbidden in QOM device names (see commit b447378e1217 - "Limit type names to alphanumerical and some few special characters"). For the

Re: [PATCH 1/2] target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules

2024-01-11 Thread Thomas Huth
On 12/01/2024 05.57, Harsh Prateek Bora wrote: On 1/11/24 22:16, Thomas Huth wrote: The character "+" is now forbidden in QOM device names (see commit b447378e1217 - "Limit type names to alphanumerical and some few special characters"). For the "power5+" and "power7+" CPU names, there is

Re: [PATCH 1/2] target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules

2024-01-11 Thread Harsh Prateek Bora
On 1/11/24 22:16, Thomas Huth wrote: The character "+" is now forbidden in QOM device names (see commit b447378e1217 - "Limit type names to alphanumerical and some few special characters"). For the "power5+" and "power7+" CPU names, there is currently a hack in type_name_is_valid() to still

Re: [PATCH 1/2] target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules

2024-01-11 Thread Cédric Le Goater
On 1/11/24 17:46, Thomas Huth wrote: The character "+" is now forbidden in QOM device names (see commit b447378e1217 - "Limit type names to alphanumerical and some few special characters"). For the "power5+" and "power7+" CPU names, there is currently a hack in type_name_is_valid() to still

[PATCH 1/2] target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules

2024-01-11 Thread Thomas Huth
The character "+" is now forbidden in QOM device names (see commit b447378e1217 - "Limit type names to alphanumerical and some few special characters"). For the "power5+" and "power7+" CPU names, there is currently a hack in type_name_is_valid() to still allow them for compatibility reasons.