Re: [PATCH 1/3] hw/acpi: Provide stub version of acpi_ghes_record_errors()

2021-06-17 Thread Peter Maydell
On Thu, 17 Jun 2021 at 11:28, Paolo Bonzini wrote: > > On 03/06/21 20:52, Richard Henderson wrote: > > On 6/3/21 10:12 AM, Peter Maydell wrote: > >> +softmmu_ss.add(when: 'CONFIG_ACPI', if_false: files('acpi-stub.c', > >> 'aml-build-stub.c', 'ghes-stub.c')) > >> softmmu_ss.add_all(when:

Re: [PATCH 1/3] hw/acpi: Provide stub version of acpi_ghes_record_errors()

2021-06-17 Thread Paolo Bonzini
On 03/06/21 20:52, Richard Henderson wrote: On 6/3/21 10:12 AM, Peter Maydell wrote: +softmmu_ss.add(when: 'CONFIG_ACPI', if_false: files('acpi-stub.c', 'aml-build-stub.c', 'ghes-stub.c'))   softmmu_ss.add_all(when: 'CONFIG_ACPI', if_true: acpi_ss)   softmmu_ss.add(when: 'CONFIG_ALL', if_true:

Re: [PATCH 1/3] hw/acpi: Provide stub version of acpi_ghes_record_errors()

2021-06-13 Thread Dongjiu Geng
On Fri, 4 Jun 2021 at 01:13, Peter Maydell wrote: > > Generic code in target/arm wants to call acpi_ghes_record_errors(); > provide a stub version so that we don't fail to link when > CONFIG_ACPI_APEI is not set. This requires us to add a new > ghes-stub.c file to contain it and the meson.build

Re: [PATCH 1/3] hw/acpi: Provide stub version of acpi_ghes_record_errors()

2021-06-03 Thread Richard Henderson
On 6/3/21 10:12 AM, Peter Maydell wrote: +softmmu_ss.add(when: 'CONFIG_ACPI', if_false: files('acpi-stub.c', 'aml-build-stub.c', 'ghes-stub.c')) softmmu_ss.add_all(when: 'CONFIG_ACPI', if_true: acpi_ss) softmmu_ss.add(when: 'CONFIG_ALL', if_true: files('acpi-stub.c', 'aml-build-stub.c', -

[PATCH 1/3] hw/acpi: Provide stub version of acpi_ghes_record_errors()

2021-06-03 Thread Peter Maydell
Generic code in target/arm wants to call acpi_ghes_record_errors(); provide a stub version so that we don't fail to link when CONFIG_ACPI_APEI is not set. This requires us to add a new ghes-stub.c file to contain it and the meson.build mechanics to use it when appropriate. Signed-off-by: Peter