Re: [PATCH 1/3] hw/i2c: add support for PMBus

2021-05-04 Thread Joel Stanley
On Tue, 4 May 2021 at 16:30, Titus Rwantare wrote: > > QEMU has support for SMBus devices, and PMBus is a more specific > implementation of SMBus. The additions made in this commit makes it easier to > add new PMBus devices to QEMU. > > https://pmbus.org/specification-archives/ I'm not a pmbus

Re: [PATCH 1/3] hw/i2c: add support for PMBus

2021-05-04 Thread Titus Rwantare
Hi Phil, It looks big but the bulk of it is simple switch statements and definitions. Unless you mean you'd like it split despite that. Regards, Titus On Tue, 4 May 2021 at 16:49, Philippe Mathieu-Daudé wrote: > > Hi Titus, > > On 5/4/21 6:28 PM, Titus Rwantare wrote: > > QEMU has support for

Re: [PATCH 1/3] hw/i2c: add support for PMBus

2021-05-04 Thread Philippe Mathieu-Daudé
Hi Titus, On 5/4/21 6:28 PM, Titus Rwantare wrote: > QEMU has support for SMBus devices, and PMBus is a more specific > implementation of SMBus. The additions made in this commit makes it easier to > add new PMBus devices to QEMU. > > https://pmbus.org/specification-archives/ > > Reviewed-by:

[PATCH 1/3] hw/i2c: add support for PMBus

2021-05-04 Thread Titus Rwantare
QEMU has support for SMBus devices, and PMBus is a more specific implementation of SMBus. The additions made in this commit makes it easier to add new PMBus devices to QEMU. https://pmbus.org/specification-archives/ Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/arm/Kconfig