Re: [PATCH 1/3] s390x/pci: avoid double enable/disable of aif

2024-01-17 Thread Matthew Rosato
On 1/17/24 5:54 AM, Cédric Le Goater wrote: > On 1/16/24 23:31, Matthew Rosato wrote: >> Use a flag to keep track of whether AIF is currently enabled.  This can be >> used to avoid enabling/disabling AIF multiple times as well as to determine >> whether or not it should be disabled during reset

Re: [PATCH 1/3] s390x/pci: avoid double enable/disable of aif

2024-01-17 Thread Matthew Rosato
>> -    return kvm_vm_ioctl(kvm_state, KVM_S390_ZPCI_OP, ); >> +    if (!pbdev->aif) { >> +    return -EINVAL; >> +    } >> + >> +    rc = kvm_vm_ioctl(kvm_state, KVM_S390_ZPCI_OP, ); >> +    if (rc == 0) { >> +    pbev->aif = false; > > s/pbev/pbdev/ > > You fix this in patch 2. :) >

Re: [PATCH 1/3] s390x/pci: avoid double enable/disable of aif

2024-01-17 Thread Cédric Le Goater
On 1/16/24 23:31, Matthew Rosato wrote: Use a flag to keep track of whether AIF is currently enabled. This can be used to avoid enabling/disabling AIF multiple times as well as to determine whether or not it should be disabled during reset processing. Why don't we disable AIF always at reset

Re: [PATCH 1/3] s390x/pci: avoid double enable/disable of aif

2024-01-16 Thread Eric Farman
On Tue, 2024-01-16 at 17:31 -0500, Matthew Rosato wrote: > Use a flag to keep track of whether AIF is currently enabled.  This > can be > used to avoid enabling/disabling AIF multiple times as well as to > determine > whether or not it should be disabled during reset processing. > > Fixes:

[PATCH 1/3] s390x/pci: avoid double enable/disable of aif

2024-01-16 Thread Matthew Rosato
Use a flag to keep track of whether AIF is currently enabled. This can be used to avoid enabling/disabling AIF multiple times as well as to determine whether or not it should be disabled during reset processing. Fixes: d0bc7091c2 ("s390x/pci: enable adapter event notification for interpreted