Re: [PATCH 1/6] qemu-img: rebase: stop when reaching EOF of old backing file

2023-10-26 Thread Andrey Drobyshev
On 10/26/23 09:32, Michael Tokarev wrote: > 01.06.2023 22:28, Andrey Drobyshev via: >> In case when we're rebasing within one backing chain, and when target >> image >> is larger than old backing file, bdrv_is_allocated_above() ends up >> setting >> *pnum = 0.  As a result, target offset isn't gett

Re: [PATCH 1/6] qemu-img: rebase: stop when reaching EOF of old backing file

2023-10-25 Thread Michael Tokarev
01.06.2023 22:28, Andrey Drobyshev via: In case when we're rebasing within one backing chain, and when target image is larger than old backing file, bdrv_is_allocated_above() ends up setting *pnum = 0. As a result, target offset isn't getting incremented, and we get stuck in an infinite for loop

Re: [PATCH 1/6] qemu-img: rebase: stop when reaching EOF of old backing file

2023-08-25 Thread Hanna Czenczek
On 01.06.23 21:28, Andrey Drobyshev via wrote: In case when we're rebasing within one backing chain, and when target image is larger than old backing file, bdrv_is_allocated_above() ends up setting *pnum = 0. As a result, target offset isn't getting incremented, and we get stuck in an infinite f

Re: [PATCH 1/6] qemu-img: rebase: stop when reaching EOF of old backing file

2023-06-21 Thread Denis V. Lunev
On 6/1/23 21:28, Andrey Drobyshev wrote: In case when we're rebasing within one backing chain, and when target image is larger than old backing file, bdrv_is_allocated_above() ends up setting *pnum = 0. As a result, target offset isn't getting incremented, and we get stuck in an infinite for loo

Re: [PATCH 1/6] qemu-img: rebase: stop when reaching EOF of old backing file

2023-06-02 Thread Andrey Drobyshev
On 6/2/23 00:18, Michael Tokarev wrote: > 01.06.2023 22:28, Andrey Drobyshev via пишет: >> In case when we're rebasing within one backing chain, and when target >> image >> is larger than old backing file, bdrv_is_allocated_above() ends up >> setting >> *pnum = 0.  As a result, target offset isn't

Re: [PATCH 1/6] qemu-img: rebase: stop when reaching EOF of old backing file

2023-06-01 Thread Michael Tokarev
01.06.2023 22:28, Andrey Drobyshev via пишет: In case when we're rebasing within one backing chain, and when target image is larger than old backing file, bdrv_is_allocated_above() ends up setting *pnum = 0. As a result, target offset isn't getting incremented, and we get stuck in an infinite fo

[PATCH 1/6] qemu-img: rebase: stop when reaching EOF of old backing file

2023-06-01 Thread Andrey Drobyshev via
In case when we're rebasing within one backing chain, and when target image is larger than old backing file, bdrv_is_allocated_above() ends up setting *pnum = 0. As a result, target offset isn't getting incremented, and we get stuck in an infinite for loop. Let's detect this case and proceed furt