Re: [PATCH 1/9] scripts/performance: Refactor topN_perf.py

2020-10-01 Thread John Snow
On 10/1/20 4:41 PM, John Snow wrote: I realize this review comes well after you are no longer being paid to work on this, so I am offering my time to help polish your patches if you would like. Actually, I see now that you are adding your name to the MAINTAINERS file here, so I suspect you

Re: [PATCH 1/9] scripts/performance: Refactor topN_perf.py

2020-10-01 Thread John Snow
I realize this review comes well after you are no longer being paid to work on this, so I am offering my time to help polish your patches if you would like. On 8/28/20 6:40 AM, Ahmed Karaman wrote: - Apply pylint and flake8 formatting rules to the script. - Use 'tempfile' instead of '/tmp'

Re: [PATCH 1/9] scripts/performance: Refactor topN_perf.py

2020-09-18 Thread Aleksandar Markovic
On Friday, August 28, 2020, Ahmed Karaman wrote: > - Apply pylint and flake8 formatting rules to the script. > - Use 'tempfile' instead of '/tmp' for creating temporary files. > > Signed-off-by: Ahmed Karaman > --- Hello, folks. This series seems forgotten. Can some of you perhaps take a

Re: [PATCH 1/9] scripts/performance: Refactor topN_perf.py

2020-09-07 Thread Aleksandar Markovic
On Friday, August 28, 2020, Ahmed Karaman wrote: > - Apply pylint and flake8 formatting rules to the script. > - Use 'tempfile' instead of '/tmp' for creating temporary files. > > Reviewed-by: Aleksandar Markovic Reply Reply all Forward View Gmail in: *Mobile* | Older version

[PATCH 1/9] scripts/performance: Refactor topN_perf.py

2020-08-28 Thread Ahmed Karaman
- Apply pylint and flake8 formatting rules to the script. - Use 'tempfile' instead of '/tmp' for creating temporary files. Signed-off-by: Ahmed Karaman --- scripts/performance/topN_perf.py | 174 +++ 1 file changed, 87 insertions(+), 87 deletions(-) diff --git