Re: [PATCH 10/25] hmp: special case help options for object_add

2021-01-25 Thread Markus Armbruster
Paolo Bonzini writes: > On 25/01/21 13:48, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> Fix "object_add help" and "object_add TYPE,help". >>> >>> Signed-off-by: Paolo Bonzini >> Standard question when I read "Fix $interface" in a commit message: >> how >> exactly is it broken? > >

Re: [PATCH 10/25] hmp: special case help options for object_add

2021-01-25 Thread Paolo Bonzini
On 25/01/21 13:48, Markus Armbruster wrote: Paolo Bonzini writes: Fix "object_add help" and "object_add TYPE,help". Signed-off-by: Paolo Bonzini Standard question when I read "Fix $interface" in a commit message: how exactly is it broken? It doesn't work at all ("Error: parameter 'id'

Re: [PATCH 10/25] hmp: special case help options for object_add

2021-01-25 Thread Markus Armbruster
Paolo Bonzini writes: > Fix "object_add help" and "object_add TYPE,help". > > Signed-off-by: Paolo Bonzini Standard question when I read "Fix $interface" in a commit message: how exactly is it broken?

[PATCH 10/25] hmp: special case help options for object_add

2021-01-18 Thread Paolo Bonzini
Fix "object_add help" and "object_add TYPE,help". Signed-off-by: Paolo Bonzini --- include/qom/object_interfaces.h | 9 - monitor/hmp-cmds.c | 22 -- qom/object_interfaces.c | 2 +- 3 files changed, 17 insertions(+), 16 deletions(-) diff --git