Re: [PATCH 11/14] contrib/plugins/cache.c: Remove redundant check of l2_access

2024-07-29 Thread Richard Henderson
On 7/30/24 00:44, Alex Bennée wrote: From: Peter Maydell In append_stats_line(), we have an expression l2_access ? l2_miss_rate : 0.0 But this is inside an if (l2_access && l2_misses) { ... } block, so Coverity points out that the false part of the ?: is dead code. Remove the unnecessary te

[PATCH 11/14] contrib/plugins/cache.c: Remove redundant check of l2_access

2024-07-29 Thread Alex Bennée
From: Peter Maydell In append_stats_line(), we have an expression l2_access ? l2_miss_rate : 0.0 But this is inside an if (l2_access && l2_misses) { ... } block, so Coverity points out that the false part of the ?: is dead code. Remove the unnecessary test. Resolves: Coverity CID 1522458 Sig