Re: [PATCH 13/37] qapi/common.py: add notational type hints

2020-09-18 Thread John Snow
On 9/18/20 7:14 AM, Markus Armbruster wrote: John Snow writes: On 9/17/20 10:32 AM, Markus Armbruster wrote: Question on the subject line: what makes a type hint notational? My cover letter explains that every time I use this phrase, I mean to state that "This patch adds exclusively type

Re: [PATCH 13/37] qapi/common.py: add notational type hints

2020-09-18 Thread Markus Armbruster
John Snow writes: > On 9/17/20 10:32 AM, Markus Armbruster wrote: >> Question on the subject line: what makes a type hint notational? >> > > My cover letter explains that every time I use this phrase, I mean to > state that "This patch adds exclusively type notations and makes no > functional

Re: [PATCH 13/37] qapi/common.py: add notational type hints

2020-09-17 Thread John Snow
On 9/17/20 2:18 PM, John Snow wrote: Your type hint adds a restriction that wasn't there before. Is there a better way? I've settled on using the `object` type for now, which is slightly more restrictive than `Any`. `Any` and `object` both allow any type of argument, but `Any` effectively

Re: [PATCH 13/37] qapi/common.py: add notational type hints

2020-09-17 Thread John Snow
On 9/17/20 10:32 AM, Markus Armbruster wrote: Question on the subject line: what makes a type hint notational? My cover letter explains that every time I use this phrase, I mean to state that "This patch adds exclusively type notations and makes no functional changes to the runtime

Re: [PATCH 13/37] qapi/common.py: add notational type hints

2020-09-17 Thread Markus Armbruster
Question on the subject line: what makes a type hint notational? John Snow writes: > Signed-off-by: John Snow > --- > scripts/qapi/common.py | 27 --- > 1 file changed, 16 insertions(+), 11 deletions(-) > > diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py >

[PATCH 13/37] qapi/common.py: add notational type hints

2020-09-15 Thread John Snow
Signed-off-by: John Snow --- scripts/qapi/common.py | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py index 4c079755d3..af01348b35 100644 --- a/scripts/qapi/common.py +++ b/scripts/qapi/common.py @@