Re: [PATCH 13/52] migration/rdma: Make qemu_rdma_buffer_mergable() return bool

2023-09-27 Thread Markus Armbruster
Eric Blake writes: > On Mon, Sep 18, 2023 at 04:41:27PM +0200, Markus Armbruster wrote: >> qemu_rdma_buffer_mergable() is semantically a predicate. It returns >> int 0 or 1. Return bool instead. > > While at it, this would be a perfect time to s/mergable/mergeable/g Will do, thanks!

Re: [PATCH 13/52] migration/rdma: Make qemu_rdma_buffer_mergable() return bool

2023-09-27 Thread Eric Blake
On Mon, Sep 18, 2023 at 04:41:27PM +0200, Markus Armbruster wrote: > qemu_rdma_buffer_mergable() is semantically a predicate. It returns > int 0 or 1. Return bool instead. While at it, this would be a perfect time to s/mergable/mergeable/g > > Signed-off-by: Markus Armbruster > --- > migrati

Re: [PATCH 13/52] migration/rdma: Make qemu_rdma_buffer_mergable() return bool

2023-09-22 Thread Zhijian Li (Fujitsu)
On 18/09/2023 22:41, Markus Armbruster wrote: > qemu_rdma_buffer_mergable() is semantically a predicate. It returns > int 0 or 1. Return bool instead. > > Signed-off-by: Markus Armbruster Reviewed-by: Li Zhijian

Re: [PATCH 13/52] migration/rdma: Make qemu_rdma_buffer_mergable() return bool

2023-09-18 Thread Fabiano Rosas
Markus Armbruster writes: > qemu_rdma_buffer_mergable() is semantically a predicate. It returns > int 0 or 1. Return bool instead. > > Signed-off-by: Markus Armbruster Reviewed-by: Fabiano Rosas

[PATCH 13/52] migration/rdma: Make qemu_rdma_buffer_mergable() return bool

2023-09-18 Thread Markus Armbruster
qemu_rdma_buffer_mergable() is semantically a predicate. It returns int 0 or 1. Return bool instead. Signed-off-by: Markus Armbruster --- migration/rdma.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/migration/rdma.c b/migration/rdma.c index 98520a42b4