Re: [PATCH 15/19] qapi/parser: demote QAPIExpression to Dict[str, Any]

2024-01-09 Thread Markus Armbruster
John Snow writes: > On Thu, Nov 23, 2023 at 9:12 AM Markus Armbruster wrote: >> >> John Snow writes: >> >> > Dict[str, object] is a stricter type, but with the way that code is >> > currently arranged, it is infeasible to enforce this strictness. >> > >> > In particular, although expr.py's enti

Re: [PATCH 15/19] qapi/parser: demote QAPIExpression to Dict[str, Any]

2024-01-09 Thread John Snow
On Thu, Nov 23, 2023 at 9:12 AM Markus Armbruster wrote: > > John Snow writes: > > > Dict[str, object] is a stricter type, but with the way that code is > > currently arranged, it is infeasible to enforce this strictness. > > > > In particular, although expr.py's entire raison d'être is normaliza

Re: [PATCH 15/19] qapi/parser: demote QAPIExpression to Dict[str, Any]

2023-11-23 Thread Markus Armbruster
John Snow writes: > Dict[str, object] is a stricter type, but with the way that code is > currently arranged, it is infeasible to enforce this strictness. > > In particular, although expr.py's entire raison d'être is normalization > and type-checking of QAPI Expressions, that type information is

[PATCH 15/19] qapi/parser: demote QAPIExpression to Dict[str, Any]

2023-11-15 Thread John Snow
Dict[str, object] is a stricter type, but with the way that code is currently arranged, it is infeasible to enforce this strictness. In particular, although expr.py's entire raison d'être is normalization and type-checking of QAPI Expressions, that type information is not "remembered" in any meani