Re: [PATCH 15/37] qapi/common.py: split build_params into new file

2020-09-17 Thread John Snow
On 9/17/20 10:42 AM, Markus Armbruster wrote: Ugh. Would moving it gen.py work? Done.

Re: [PATCH 15/37] qapi/common.py: split build_params into new file

2020-09-17 Thread John Snow
On 9/17/20 10:42 AM, Markus Armbruster wrote: John Snow writes: Including it in common.py creates a circular import dependency, because schema relies on common.py. To type build_params properly, it needs to be moved outside of the chain. Signed-off-by: John Snow ---

Re: [PATCH 15/37] qapi/common.py: split build_params into new file

2020-09-17 Thread Markus Armbruster
John Snow writes: > Including it in common.py creates a circular import dependency, because > schema relies on common.py. To type build_params properly, it needs to > be moved outside of the chain. > > Signed-off-by: John Snow > --- > scripts/qapi/commands.py | 2 +- > scripts/qapi/common.py

[PATCH 15/37] qapi/common.py: split build_params into new file

2020-09-15 Thread John Snow
Including it in common.py creates a circular import dependency, because schema relies on common.py. To type build_params properly, it needs to be moved outside of the chain. Signed-off-by: John Snow --- scripts/qapi/commands.py | 2 +- scripts/qapi/common.py | 23 ---