Re: [PATCH 19/22] target/i386: move operand load and writeback out of gen_cmovcc1

2023-12-28 Thread Richard Henderson
On 12/23/23 05:16, Paolo Bonzini wrote: Similar to gen_setcc1, make gen_cmovcc1 receive TCGv. This is more friendly to simultaneous implementation in the old and the new decoder. A small wart is that s->T0 of CMOV is currently the*second* argument (which would ordinarily be in T1). Therefore,

[PATCH 19/22] target/i386: move operand load and writeback out of gen_cmovcc1

2023-12-22 Thread Paolo Bonzini
Similar to gen_setcc1, make gen_cmovcc1 receive TCGv. This is more friendly to simultaneous implementation in the old and the new decoder. A small wart is that s->T0 of CMOV is currently the *second* argument (which would ordinarily be in T1). Therefore, the condition has to be inverted in order