Re: [PATCH 2/2] acpi/nvdimm: Fix aml_or() and aml_and() in if clause

2022-05-13 Thread Michael S. Tsirkin
On Tue, Apr 12, 2022 at 02:57:53PM +0800, Robert Hoo wrote: > It should be some typo originally, where in If condition, using bitwise > and/or, rather than logical and/or. > > The resulting change in AML code: > > If (((Local6 == Zero) | (Arg0 != Local0))) > ==> > If (((Local6 == Zero) || (Arg0

Re: [PATCH 2/2] acpi/nvdimm: Fix aml_or() and aml_and() in if clause

2022-04-27 Thread Igor Mammedov
On Tue, 12 Apr 2022 14:57:53 +0800 Robert Hoo wrote: > It should be some typo originally, where in If condition, using bitwise > and/or, rather than logical and/or. > > The resulting change in AML code: > > If (((Local6 == Zero) | (Arg0 != Local0))) > ==> > If (((Local6 == Zero) || (Arg0 !=

[PATCH 2/2] acpi/nvdimm: Fix aml_or() and aml_and() in if clause

2022-04-12 Thread Robert Hoo
It should be some typo originally, where in If condition, using bitwise and/or, rather than logical and/or. The resulting change in AML code: If (((Local6 == Zero) | (Arg0 != Local0))) ==> If (((Local6 == Zero) || (Arg0 != Local0))) If (((ObjectType (Arg3) == 0x04) & (SizeOf (Arg3) == One)))