Re: [PATCH 2/2] target/arm: Check V7VE as well as LPAE in arm_pamax

2022-06-24 Thread Richard Henderson
On 6/24/22 09:27, Peter Maydell wrote: +/* + * In machvirt_init, we call arm_pamax on a cpu that is not fully + * initialized, so we can't rely on the propagation done in realize. + */ +if (arm_feature(>env, ARM_FEATURE_LPAE) || +arm_feature(>env, ARM_FEATURE_V7VE)) {

Re: [PATCH 2/2] target/arm: Check V7VE as well as LPAE in arm_pamax

2022-06-24 Thread Peter Maydell
On Sun, 19 Jun 2022 at 01:18, Richard Henderson wrote: > > In machvirt_init we create a cpu but do not fully initialize it. > Thus the propagation of V7VE to LPAE has not been done, and we > compute the wrong value for some v7 cpus, e.g. cortex-a15. > > Resolves:

[PATCH 2/2] target/arm: Check V7VE as well as LPAE in arm_pamax

2022-06-18 Thread Richard Henderson
In machvirt_init we create a cpu but do not fully initialize it. Thus the propagation of V7VE to LPAE has not been done, and we compute the wrong value for some v7 cpus, e.g. cortex-a15. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1078 Signed-off-by: Richard Henderson ---