Re: [PATCH 2/2] vhost-user: Call qemu_socketpair() instead of socketpair()

2022-08-18 Thread Guoyi Tu
On 8/12/22 19:50, Peter Maydell wrote: On Fri, 12 Aug 2022 at 12:44, wrote: From: Guoyi Tu set close-on-exec flag on the new opened file descriptors at default What goes wrong if we don't do this? The commit message is a good place to explain what bug the commit is fixing, and its

Re: [PATCH 2/2] vhost-user: Call qemu_socketpair() instead of socketpair()

2022-08-12 Thread Peter Maydell
On Fri, 12 Aug 2022 at 12:44, wrote: > > From: Guoyi Tu > > set close-on-exec flag on the new opened file descriptors at default What goes wrong if we don't do this? The commit message is a good place to explain what bug the commit is fixing, and its consequences. thanks -- PMM

[PATCH 2/2] vhost-user: Call qemu_socketpair() instead of socketpair()

2022-08-12 Thread tugy
From: Guoyi Tu set close-on-exec flag on the new opened file descriptors at default Signed-off-by: Guoyi Tu --- hw/display/vhost-user-gpu.c | 3 ++- hw/virtio/vhost-user.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/display/vhost-user-gpu.c