Re: [PATCH 2/3] hw/acpi-build: account for NVDIMM numa nodes in SRAT

2020-05-28 Thread Verma, Vishal L
On Thu, 2020-05-28 at 12:41 +0200, Igor Mammedov wrote: > On Thu, 28 May 2020 01:24:42 + > "Verma, Vishal L" wrote: > > On Thu, 2020-05-21 at 17:16 +0200, Igor Mammedov wrote: > > [..] > > > > > > There is ARM version of build_srat(), > > > I suggest to put this NVDIMM specific part in

Re: [PATCH 2/3] hw/acpi-build: account for NVDIMM numa nodes in SRAT

2020-05-28 Thread Igor Mammedov
On Thu, 28 May 2020 01:24:42 + "Verma, Vishal L" wrote: > On Thu, 2020-05-21 at 17:16 +0200, Igor Mammedov wrote: > > Hi Igor, Thanks for the review. > > [..] > > > > > > @@ -2429,6 +2430,25 @@ build_srat(GArray *table_data, BIOSLinker *linker, > > > MachineState *machine) > > >

Re: [PATCH 2/3] hw/acpi-build: account for NVDIMM numa nodes in SRAT

2020-05-27 Thread Verma, Vishal L
On Thu, 2020-05-21 at 17:16 +0200, Igor Mammedov wrote: Hi Igor, Thanks for the review. [..] > > > > @@ -2429,6 +2430,25 @@ build_srat(GArray *table_data, BIOSLinker *linker, > > MachineState *machine) > >MEM_AFFINITY_ENABLED); > > } > > } > > + >

Re: [PATCH 2/3] hw/acpi-build: account for NVDIMM numa nodes in SRAT

2020-05-21 Thread Igor Mammedov
On Mon, 27 Apr 2020 19:28:09 -0600 Vishal Verma wrote: > NVDIMMs can belong to their own proximity domains, as described by the > NFIT. In such cases, the SRAT needs to have Memory Affinity structures > in the SRAT for these NVDIMMs, otherwise Linux doesn't populate node > data structures

Re: [PATCH 2/3] hw/acpi-build: account for NVDIMM numa nodes in SRAT

2020-04-29 Thread Liu, Jingqi
On 4/28/2020 9:28 AM, Verma, Vishal L wrote: NVDIMMs can belong to their own proximity domains, as described by the NFIT. In such cases, the SRAT needs to have Memory Affinity structures in the SRAT for these NVDIMMs, otherwise Linux doesn't populate node data structures properly during NUMA

[PATCH 2/3] hw/acpi-build: account for NVDIMM numa nodes in SRAT

2020-04-27 Thread Vishal Verma
NVDIMMs can belong to their own proximity domains, as described by the NFIT. In such cases, the SRAT needs to have Memory Affinity structures in the SRAT for these NVDIMMs, otherwise Linux doesn't populate node data structures properly during NUMA initialization. See the following for an example