Re: [PATCH 2/3] ppc: rs6000_mc: drop usage of memory_region_allocate_system_memory()

2019-10-09 Thread David Gibson
On Wed, Oct 09, 2019 at 01:19:21PM +0200, Igor Mammedov wrote: > On Wed, 9 Oct 2019 12:21:06 +1100 > David Gibson wrote: > > > On Tue, Oct 08, 2019 at 07:33:17AM -0400, Igor Mammedov wrote: > > > rs6000mc_realize() violates memory_region_allocate_system_memory() > > > contract > > > by calling

Re: [PATCH 2/3] ppc: rs6000_mc: drop usage of memory_region_allocate_system_memory()

2019-10-09 Thread Igor Mammedov
On Wed, 9 Oct 2019 12:21:06 +1100 David Gibson wrote: > On Tue, Oct 08, 2019 at 07:33:17AM -0400, Igor Mammedov wrote: > > rs6000mc_realize() violates memory_region_allocate_system_memory() contract > > by calling it multiple times which could break -mem-path. Replace it with > > plain

Re: [PATCH 2/3] ppc: rs6000_mc: drop usage of memory_region_allocate_system_memory()

2019-10-08 Thread David Gibson
On Tue, Oct 08, 2019 at 07:33:17AM -0400, Igor Mammedov wrote: > rs6000mc_realize() violates memory_region_allocate_system_memory() contract > by calling it multiple times which could break -mem-path. Replace it with > plain memory_region_init_ram() instead. > > Signed-off-by: Igor Mammedov

Re: [PATCH 2/3] ppc: rs6000_mc: drop usage of memory_region_allocate_system_memory()

2019-10-08 Thread Philippe Mathieu-Daudé
On 10/8/19 1:33 PM, Igor Mammedov wrote: rs6000mc_realize() violates memory_region_allocate_system_memory() contract by calling it multiple times which could break -mem-path. Replace it with plain memory_region_init_ram() instead. Signed-off-by: Igor Mammedov Reviewed-by: Philippe

[PATCH 2/3] ppc: rs6000_mc: drop usage of memory_region_allocate_system_memory()

2019-10-08 Thread Igor Mammedov
rs6000mc_realize() violates memory_region_allocate_system_memory() contract by calling it multiple times which could break -mem-path. Replace it with plain memory_region_init_ram() instead. Signed-off-by: Igor Mammedov --- hw/ppc/rs6000_mc.c | 15 ++- 1 file changed, 10