Re: [PATCH 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Greg Kurz
On Wed, 10 Jun 2020 21:03:15 +0300 Vladimir Sementsov-Ogievskiy wrote: > 10.06.2020 20:17, Greg Kurz wrote: > > We have a dedicated error API for hints. Use it instead of embedding > > the hint in the error message, as recommanded in the "qapi/error.h" > > header file. > > > > Since spapr_caps_a

Re: [PATCH 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-10 Thread Vladimir Sementsov-Ogievskiy
10.06.2020 20:17, Greg Kurz wrote: We have a dedicated error API for hints. Use it instead of embedding the hint in the error message, as recommanded in the "qapi/error.h" header file. Since spapr_caps_apply() passes &error_fatal, all functions must also call the ERRP_AUTO_PROPAGATE() macro for

[PATCH 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-10 Thread Greg Kurz
We have a dedicated error API for hints. Use it instead of embedding the hint in the error message, as recommanded in the "qapi/error.h" header file. Since spapr_caps_apply() passes &error_fatal, all functions must also call the ERRP_AUTO_PROPAGATE() macro for error_append_hint() to be functional.