Re: [PATCH 2/4] target/arm: Fixup contiguous first-fault and no-fault loads

2020-12-10 Thread LIU Zhiwei
On 2020/12/9 4:16, Richard Henderson wrote: On 12/6/20 10:46 PM, LIU Zhiwei wrote: First-fault or no-fault doesn't mean only access one page. But the implementation is *allowed* to access only one page. Thus the comment: -/* - * MemSingleNF is allowed to fail for any reason. We

Re: [PATCH 2/4] target/arm: Fixup contiguous first-fault and no-fault loads

2020-12-08 Thread Richard Henderson
On 12/6/20 10:46 PM, LIU Zhiwei wrote: > First-fault or no-fault doesn't mean only access one page. But the implementation is *allowed* to access only one page. Thus the comment: > -/* > - * MemSingleNF is allowed to fail for any reason. We have special > - * code above to handle

[PATCH 2/4] target/arm: Fixup contiguous first-fault and no-fault loads

2020-12-06 Thread LIU Zhiwei
First-fault or no-fault doesn't mean only access one page. When cross pages, for first-fault, if there is no fault in the first access, the second page should be accessed. And for no-fault, the second page should always be accessed. Signed-off-by: LIU Zhiwei --- target/arm/sve_helper.c | 35