Re: [PATCH 2/5] hw/mips/fuloong2e: Convert pointless error message to an assert()

2020-09-09 Thread Laurent Vivier
Le 01/09/2020 à 12:40, Philippe Mathieu-Daudé a écrit : > Displaying "vt82c686b_init error" doesn't give any hint about why > this call failed. As this message targets developers and not users, > replace the pointless error message by a call to assert() which > will provide more useful

Re: [PATCH 2/5] hw/mips/fuloong2e: Convert pointless error message to an assert()

2020-09-01 Thread Richard Henderson
On 9/1/20 3:40 AM, Philippe Mathieu-Daudé wrote: > Displaying "vt82c686b_init error" doesn't give any hint about why > this call failed. As this message targets developers and not users, > replace the pointless error message by a call to assert() which > will provide more useful information. > >

Re: [PATCH 2/5] hw/mips/fuloong2e: Convert pointless error message to an assert()

2020-09-01 Thread chen huacai
Reviewed-by: Huacai Chen On Tue, Sep 1, 2020 at 6:41 PM Philippe Mathieu-Daudé wrote: > > Displaying "vt82c686b_init error" doesn't give any hint about why > this call failed. As this message targets developers and not users, > replace the pointless error message by a call to assert() which >

[PATCH 2/5] hw/mips/fuloong2e: Convert pointless error message to an assert()

2020-09-01 Thread Philippe Mathieu-Daudé
Displaying "vt82c686b_init error" doesn't give any hint about why this call failed. As this message targets developers and not users, replace the pointless error message by a call to assert() which will provide more useful information. Signed-off-by: Philippe Mathieu-Daudé ---