Re: [PATCH 2/9] hw/block/nvme: fix log page offset check

2020-10-01 Thread Philippe Mathieu-Daudé
On 10/1/20 12:04 AM, Keith Busch wrote: > Return error if the requested offset starts after the size of the log > being returned. Also, move the check for earlier in the function so > we're not doing unnecessary calculations. > > Signed-off-by: Keith Busch > --- > hw/block/nvme.c | 22

Re: [PATCH 2/9] hw/block/nvme: fix log page offset check

2020-09-30 Thread Klaus Jensen
On Sep 30 15:04, Keith Busch wrote: > Return error if the requested offset starts after the size of the log > being returned. Also, move the check for earlier in the function so > we're not doing unnecessary calculations. > > Signed-off-by: Keith Busch Reviewed-by: Klaus Jensen > --- >

RE: [PATCH 2/9] hw/block/nvme: fix log page offset check

2020-09-30 Thread Dmitry Fomichev
> -Original Message- > From: Keith Busch > Sent: Wednesday, September 30, 2020 6:04 PM > To: qemu-bl...@nongnu.org; qemu-devel@nongnu.org; Klaus Jensen > > Cc: Niklas Cassel ; Dmitry Fomichev > ; Kevin Wolf ; Philippe > Mathieu-Daudé ; Keith Busch > Subject

[PATCH 2/9] hw/block/nvme: fix log page offset check

2020-09-30 Thread Keith Busch
Return error if the requested offset starts after the size of the log being returned. Also, move the check for earlier in the function so we're not doing unnecessary calculations. Signed-off-by: Keith Busch --- hw/block/nvme.c | 22 ++ 1 file changed, 10 insertions(+), 12