Re: [PATCH 20/20] tests: Add postcopy preempt test

2022-03-01 Thread Peter Xu
On Tue, Mar 01, 2022 at 05:00:15PM +, Dr. David Alan Gilbert wrote: > > That's tricky, and we could have done something better.. E.g., we could > > pass in the MigrateStart** into test_migrate_start() so it can clear it > > when free, that's not silent use-after-free but crashing, which is

Re: [PATCH 20/20] tests: Add postcopy preempt test

2022-03-01 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Feb 23, 2022 at 03:50:24PM +0800, Peter Xu wrote: > > On Tue, Feb 22, 2022 at 12:51:59PM +, Dr. David Alan Gilbert wrote: > > > * Peter Xu (pet...@redhat.com) wrote: > > > > Two tests are added: a normal postcopy preempt test, and a recovery > >

Re: [PATCH 20/20] tests: Add postcopy preempt test

2022-02-28 Thread Peter Xu
On Wed, Feb 23, 2022 at 03:50:24PM +0800, Peter Xu wrote: > On Tue, Feb 22, 2022 at 12:51:59PM +, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > Two tests are added: a normal postcopy preempt test, and a recovery test. > > > > Yes, this is difficult; without

Re: [PATCH 20/20] tests: Add postcopy preempt test

2022-02-22 Thread Peter Xu
On Tue, Feb 22, 2022 at 12:51:59PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Two tests are added: a normal postcopy preempt test, and a recovery test. > > Yes, this is difficult; without hugepages the tests are limited; did you > see if this test actually

Re: [PATCH 20/20] tests: Add postcopy preempt test

2022-02-22 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Two tests are added: a normal postcopy preempt test, and a recovery test. Yes, this is difficult; without hugepages the tests are limited; did you see if this test actually causes pages to go down the fast path? Reviewed-by: Dr. David Alan Gilbert >

[PATCH 20/20] tests: Add postcopy preempt test

2022-02-16 Thread Peter Xu
Two tests are added: a normal postcopy preempt test, and a recovery test. Signed-off-by: Peter Xu --- tests/qtest/migration-test.c | 39 ++-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/tests/qtest/migration-test.c