Re: [PATCH 20/36] target/arm: Convert Neon 3-reg-same VQRDMLAH/VQRDMLSH to decodetree

2020-05-01 Thread Peter Maydell
On Thu, 30 Apr 2020 at 21:28, Richard Henderson wrote: > > On 4/30/20 11:09 AM, Peter Maydell wrote: > > These don't use do_3same() because they want to > > operate on VFP double registers, whose offsets are different from the > > neon_reg_offset() calculations do_3same does. > > Actually, no,

Re: [PATCH 20/36] target/arm: Convert Neon 3-reg-same VQRDMLAH/VQRDMLSH to decodetree

2020-04-30 Thread Richard Henderson
On 4/30/20 11:09 AM, Peter Maydell wrote: > These don't use do_3same() because they want to > operate on VFP double registers, whose offsets are different from the > neon_reg_offset() calculations do_3same does. Actually, no, it's an around the bush way of computing the same register offset.

Re: [PATCH 20/36] target/arm: Convert Neon 3-reg-same VQRDMLAH/VQRDMLSH to decodetree

2020-04-30 Thread Richard Henderson
On 4/30/20 11:09 AM, Peter Maydell wrote: > Convert the Neon VQRDMLAH and VQRDMLSH insns in the 3-reg-same group > to decodetree. These don't use do_3same() because they want to > operate on VFP double registers, whose offsets are different from the > neon_reg_offset() calculations do_3same does.

[PATCH 20/36] target/arm: Convert Neon 3-reg-same VQRDMLAH/VQRDMLSH to decodetree

2020-04-30 Thread Peter Maydell
Convert the Neon VQRDMLAH and VQRDMLSH insns in the 3-reg-same group to decodetree. These don't use do_3same() because they want to operate on VFP double registers, whose offsets are different from the neon_reg_offset() calculations do_3same does. Signed-off-by: Peter Maydell ---