Re: [PATCH 21/52] migration/rdma: Fix QEMUFileHooks method return values

2023-09-25 Thread Zhijian Li (Fujitsu)
On 25/09/2023 14:36, Markus Armbruster wrote: > "Zhijian Li (Fujitsu)" writes: > >> On 18/09/2023 22:41, Markus Armbruster wrote: >>> The QEMUFileHooks methods don't come with a written contract. Digging >>> through the code calling them, we find: >>> >>> * save_page(): >> >> I'm fine with thi

Re: [PATCH 21/52] migration/rdma: Fix QEMUFileHooks method return values

2023-09-24 Thread Markus Armbruster
"Zhijian Li (Fujitsu)" writes: > On 18/09/2023 22:41, Markus Armbruster wrote: >> The QEMUFileHooks methods don't come with a written contract. Digging >> through the code calling them, we find: >> >> * save_page(): > > I'm fine with this > >> >>Negative values RAM_SAVE_CONTROL_DELAYED and

Re: [PATCH 21/52] migration/rdma: Fix QEMUFileHooks method return values

2023-09-24 Thread Zhijian Li (Fujitsu)
On 18/09/2023 22:41, Markus Armbruster wrote: > The QEMUFileHooks methods don't come with a written contract. Digging > through the code calling them, we find: > > * save_page(): I'm fine with this > >Negative values RAM_SAVE_CONTROL_DELAYED and >RAM_SAVE_CONTROL_NOT_SUPP are special

[PATCH 21/52] migration/rdma: Fix QEMUFileHooks method return values

2023-09-18 Thread Markus Armbruster
The QEMUFileHooks methods don't come with a written contract. Digging through the code calling them, we find: * save_page(): Negative values RAM_SAVE_CONTROL_DELAYED and RAM_SAVE_CONTROL_NOT_SUPP are special. Any other negative value is an unspecified error. qemu_rdma_save_page() retur