Re: [PATCH 26/36] remove preconfig state

2020-11-30 Thread Igor Mammedov
On Fri, 27 Nov 2020 12:50:39 +0100 Paolo Bonzini wrote: > On 27/11/20 11:50, Igor Mammedov wrote: > > it works in context of this series since > > > >+qemu_init_board(); > >+qemu_create_cli_devices(); > >+qemu_machine_creation_done(); > > > > are called within the same

Re: [PATCH 26/36] remove preconfig state

2020-11-27 Thread Paolo Bonzini
On 27/11/20 11:50, Igor Mammedov wrote: it works in context of this series since +qemu_init_board(); +qemu_create_cli_devices(); +qemu_machine_creation_done(); are called within the same command qmp_x_exit_preconfig, if preconfig is enabled we happen to call

Re: [PATCH 26/36] remove preconfig state

2020-11-27 Thread Igor Mammedov
On Fri, 27 Nov 2020 06:19:51 +0100 Paolo Bonzini wrote: > On 26/11/20 19:55, Igor Mammedov wrote: > > On Mon, 23 Nov 2020 09:14:25 -0500 > > Paolo Bonzini wrote: > > > >> The preconfig state is only used if -incoming is not specified, which > >> makes the RunState state machine more tricky

Re: [PATCH 26/36] remove preconfig state

2020-11-26 Thread Paolo Bonzini
On 26/11/20 19:55, Igor Mammedov wrote: On Mon, 23 Nov 2020 09:14:25 -0500 Paolo Bonzini wrote: The preconfig state is only used if -incoming is not specified, which makes the RunState state machine more tricky than it need be. However there is already an equivalent condition which works

Re: [PATCH 26/36] remove preconfig state

2020-11-26 Thread Igor Mammedov
On Mon, 23 Nov 2020 09:14:25 -0500 Paolo Bonzini wrote: > The preconfig state is only used if -incoming is not specified, which > makes the RunState state machine more tricky than it need be. However > there is already an equivalent condition which works even with -incoming, > namely

[PATCH 26/36] remove preconfig state

2020-11-23 Thread Paolo Bonzini
The preconfig state is only used if -incoming is not specified, which makes the RunState state machine more tricky than it need be. However there is already an equivalent condition which works even with -incoming, namely qdev_hotplug. Use it instead of a separate runstate. Signed-off-by: Paolo